PHP acts differently depending on computer

Question

I have an issue with php where code works on on computer but wont work on another

    function appendParam(&$req, $name, $value) {
 if (req == null) {
  return;
 }
 if (name == null) {
  return;
 }
 if (value != null) {
  $req[$name] = $value;
 }
}

The above works on one computer and is capable of checking req and name against null properly and the variables is the if condition don't need dollar signs (when i put the dollar signs in they break on this computer)

but i need to use the following code on another computer to get the same end result

    function appendParam(&$req, $name, $value) {
    if ($value != null) {
  $req[$name] = $value;
 } 
    if ($name == null) {
  return;
 }
    if ($req == null) {
  return;
 }
}

on this other computer it isn't capable of checking name or req against null (it breaks) and i need the dollar signs on the variables in the if condition.

As a side note it also seems that this computer can't read from an array index that isn't already initialized.

Any help is appreciated

Answer 1

Could it be one of the computers is using an older version of PHP?

Answer 2

The 2 machines might have different warning levels or error reporting levels.

I'm confused, surely you should have the $ prefix before any php variable name otherwise you're not actually checking on the variable? What are you trying to achieve by not using the $ prefix

Answer 3

This code makes very little sense to me:

    function appendParam(&$req, $name, $value) {
    if ($value != null) {
                $req[$name] = $value;
        }       
    if ($name == null) {
                return;
        }
    if ($req == null) {
                return;
        }
}

It should be written like so:

function appendParam(&$req, $name, $value)
{
 if(empty($name) || empty($value) || empty($req))
  return;

 $req[$name] = $value;
}

When you say it "breaks" can you give a specific example/error you're getting and how you're using the function? I'm thinking you're using it incorrectly.