Best way to generate a random color in javascript?

Question

Without using any framework..

I wrote 2 functions:

function get_random_color() 
{
    var color = "";
    for(var i = 0; i < 3; i++) {
     var sub = Math.floor(Math.random() * 256).toString(16);
     color += (sub.length == 1 ? "0" + sub : sub);
    }
    return "#" + color;
}

function get_rand_color()
{
    var color = Math.floor(Math.random() * Math.pow(256, 3)).toString(16);
    while(color.length < 6) {
     color = "0" + color;
    }
    return "#" + color;
}

Which would be considered the better one? Are there better ways to do it?

Answer 1

More succinct:

function get_random_color2() 
{
    var r = function () { return Math.floor(Math.random()*256) };
    return "rgb(" + r() + "," + r() + "," + r() + ")";
}

Answer 2

I like your second option, although it can be made a little bit simpler:

// Math.pow is slow, use constant instead.
var color = Math.floor(Math.random() * 16777216).toString(16);
// Avoid loops.
return '#000000'.slice(0, -color.length) + color;

Answer 3

A shorter way:

'#'+(0x1000000+(Math.random())*0xffffff).toString(16).substr(1,6)