ansaurus

Question

page.insert_html does not insert html with link_to_function (rails)

Answer 1

A:

Could you show the generated html+js source?

Lichtamberg 2009-07-28 16:36:25

I've just edited the question with the code ;)

Víctor 2009-07-28 16:46:08

How do you generate the other divs?The dont look well formated f.e. Element.insert("groups",..should be Element.insert(""groups"",...

Lichtamberg 2009-07-29 07:41:51

Answer 2

A:

You are doing it wrong. This ends up inserting an escaped partial into and escaped string in an HTML attribute. That is simply evil. And there are tons of ways it can break.

You might want to consider a simpler approach. Put the render :partial above the link_to_function 'Add a group'. Make the div#group hidden and then have the link to $('group').show().

In other words, make it hidden and then show it with JavaScript, instead of inserting it in the DOM. Simpler and less-error prone.

Stefan Kanev 2009-07-29 13:18:39

But, in that way I can't add as much as I want, can I? I mean, there's only one hidden, and I want it to be able to add as many as the user wants.

Víctor 2009-07-29 15:05:27

Answer 3

A:

I managed to make this work. In my opinion, this is a bug in Rails because of using escape_once instead of html_escape. In other words, the first link_to_function is escaped, but the second isn't, just because the string is already escaped. This makes that the reverse operation (de-escaping or whatever) doesn't work. You could add this code to an initializer to always escape:

module ActionView
  module Helpers
    module TagHelper
      private
        def tag_options(options, escape = true)
          unless options.blank?
            attrs = []
            if escape
              options.each do |key, value|
                next unless value
                key = key.to_s
                value = BOOLEAN_ATTRIBUTES.include?(key) ? key : ERB::Util::html_escape(value)
                attrs << %(#{key}="#{value}")
              end
            else
              attrs = options.map { |key, value| %(#{key}="#{value}") }
            end
            " #{attrs.sort * ' '}" unless attrs.empty?
          end
        end
    end
  end
end

This code might break things, so use it with care. However, I've read that maybe escape_once is changed in Rails 3.0, so keep your fingers crossed ;)

Jose 2009-12-08 17:53:46

ansaurus

tags:

views:

answers:

page.insert_html does not insert html with link_to_function (rails)

related questions