ruby on rails undefined method for array

Question

I have a user who owns many phones
I have a a phone which has many call summaries
therefore my user has many call summaries

Now to the code that I have:

class User < ActiveRecord::Base
    has_many :phones
    has_many :call_summaries, :through => :phones
end  

class Phone < ActiveRecord::Base
    belongs_to :user
    has_many :call_summaries
end

class CallSummary < ActiveRecord::Base
    belongs_to :phones
end

I would like to generate a report that shows all the call summaries for the phones that belong to that certain user. I go into the controller and this is my code there:

def index
  @phones = Phone.find(:all, :conditions => ["user_id = ?", @current_user.id])
  @call_summaries = @phones.call_summaries.find(:all)
end

But this is returning this error:

undefined method `call_summaries' for #Array:0x476d2d0

Any help would be very much appreciated.

Answer 1

@phones is an array of Phone objects. You have to iterate through that array and add each phone's call summaries to a single array. Try this:

@phones = Phone.find(:all, :conditions => ["user_id = ?", @current_user.id])
@call_summaries = @phones.inject([]){|arr, phone| arr + phone.call_summaries}

Answer 2

If you have the has_many :through relationship set up, you should just be able to do:

@call_summaries = @current_user.call_summaries

The problem with your method is that you're calling call_summaries on the @phones collection, rather than on individual phone instances.

Answer 3

Off topic and just me being fussy, but a dynamic finder is more readable:

@phones = Phone.find_all_by_user_id(@current_user)