views:

2513

answers:

1

The following works fine with IEnumerable types, but is there any way to get something like this working with IQueryable types against a sql database?

class Program
{
    static void Main(string[] args)
    {
        var items = new[] { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, };

        foreach (var item in items.Where(i => i.Between(2, 6)))
            Console.WriteLine(item);
    }
}

static class Ext
{
   public static bool Between<T>(this T source, T low, T high) where T : IComparable
   {
       return source.CompareTo(low) >= 0 && source.CompareTo(high) <= 0;
   }
}
+6  A: 

If you express it as a where clause it may just work out of the box with LINQ to SQL, if you can construct an appropriate expression.

There may be a better way of doing this in terms of the expression trees - Marc Gravell may well be able to improve it - but it's worth a try.

static class Ext
{
   public static IQueryable<TSource> Between<TSource, TKey>
        (this IQueryable<TSource> source, 
         Expression<Func<TSource, TKey>> keySelector,
         TKey low, TKey high) where TKey : IComparable<TKey>
   {
       Expression key = Expression.Invoke(keySelector, 
            keySelector.Parameters.ToArray());
       Expression lowerBound = Expression.LessThanOrEqual
           (Expression.Constant(low), key);
       Expression upperBound = Expression.LessThanOrEqual
           (key, Expression.Constant(high));
       Expression and = Expression.AndAlso(lowerBound, upperBound);
       Expression<Func<TSource, bool>> lambda = 
           Expression.Lambda<Func<TSource, bool>>(and, keySelector.Parameters);
       return source.Where(lambda);
   }
}

It will probably depend on the type involved though - in particular, I've used the comparison operators rather than IComparable<T>. I suspect this is more likely to be correctly translated into SQL, but you could change it to use the CompareTo method if you want.

Invoke it like this:

var query = db.People.Between(person => person.Age, 18, 21);
Jon Skeet
Nice. This also made me understand Linq expressions a bit more.
Dykam
Jon,Sorry I haven't accepted this. Been under the weather for a few days. Question: you write about using comparison operators instead of IComparable<T>. What would that look like? What would any of this look like as an IEnumerable<T>? I need to play with this and hope to do that today. Thanks much!
Andrew Robinson
Using `IComparable<T>` you'd need expression trees to invoke CompareTo twice. All doable, but a bit of a pain. Not sure what you mean about "What would any of this look like as an `IEnumerable<T>`?" - can you elaborate?
Jon Skeet
I also think this is an excellent example of code that would be more readable using the `var` keyword.
tvanfosson