I was wondering what kind of exception should one throw for missing data. For example if an xml node doesn't contain data. It would be easy to "throw new Exception(...)" but this is not recommended. Another option would be to create a new exception class like MissingDataException or InvalidDataException but isn't there a built-in exception class for this case?
+2
A:
You can use System.Xml.XmlException .
Edit : Even if System.Xml.XmlException could fit, I think you should define your own exception, as it would be more precise, and you could describe what kind of data is missing : an id, a date, etc.
Clement Herreman
2009-09-21 07:20:24
System.Xml.XmlException is used by the runtime to indicate an error reading an XML document, specifically where the XML is not of the correct format (e.g. unclosed tag, missing root element). It even includes line and character numbers. Doesn't feel like a particularly good fit to me.
Programming Hero
2009-09-21 14:33:19
If his XML shall have data in a node, and haven't any, IMO the XML isn't of the correct format, so he can show at what line (even what char number if he wants). I think this fit, even if defining his own exception would be better.
Clement Herreman
2009-09-22 07:14:03
+2
A:
Do not call "throw new Exception", because you don't know how to handle the exception.
Define your own exception. Be more specific, such as XMLDataMissingException. Then you can give a meamingful message to user or log it.
Keping
2009-09-21 08:40:29
+2
A:
As a rule of thumb, check the existing .NET framework exceptions for a suitable exception to throw before deriving your own. To answer your question directly, there is no "missing data" exception currently available to throw, but that doesn't mean there aren't suitable exceptions to cover your situation.
In your case, the humble InvalidOperationException may be suitable; this exception is thrown when you call a method on an object, but the object's state is not appropriate for the operation. Examples of this include calling methods on a closed stream and an enumerator that has passed the end of the collection. If the XML data is the internal state of an object, and a method call has discovered the bad data, InvalidOperationException is a good candidate.
If you are passing your XML data to a method, an ArgumentException, or one of its derivatives may be an appropriate choice. There is a small family of these exceptions, all indicating that an argument passed to a method is not as the method expected.
You will only want to create a custom exception when you want the exceptional circumstance to be handled differently from other exceptions. If you do choose to create your own exception, be sure to derive it from a higher exception than Exception, so that the nature of the exception is implied by the base class.
Programming Hero
2009-09-21 09:20:26
+1 I agree 100 percent, use what the system offers and only then if you can't find something that will work then create custom exceptions.
Chuck Conway
2009-09-21 09:34:51
A:
throw new Exception("my message"); (or other built in Exception) is often the correct approach. The alternative is an explosion of Exception classes that may only get used once.
If new Exceptions are warranted they should be created in the context of the domain, not the problem.
Chuck Conway
2009-09-21 09:30:25