tags:

views:

770

answers:

3

I've been putting together a list of pages that we need to update with new content (we're switching media formats). In the process I'm cataloging pages that correctly have the new content.

Here's the general idea of what I'm doing:

  1. Iterate through a file structure and get a list of files
  2. For each file read to a buffer and, using regex search, match a specific tag
  3. If matched, test 2 more regex matches
  4. write the resulting matches (one or the other) into a database

Everything works fine up until the 3rd regex pattern match, where I get the following:

'NoneType' object has no attribute 'group'

I can comment out the 2nd match and the 3rd works fine. And it's a complete mystery to me.

# only interested in embeded content
pattern = "(<embed .*?</embed>)"

# matches content pointing to our old root
pattern2 = 'data="(http://.*?/media/.*?")'

# matches content pointing to our new root
pattern3 = 'data="(http://.*?/content/.*?")'

matches = re.findall(pattern, filebuffer)
for match in matches:
 if len(match) > 0:

  urla = re.search(pattern2, match)
  if urla.group(1) is not None:
   print filename, urla.group(1)


  urlb = re.search(pattern3, match)
  if urlb.group(1) is not None:
   print filename, urlb.group(1)

as you can see, I've even tried using different variable names for the 2nd and 3rd pattern matches, which doesn't help at all. if i comment the entire URLA block, URLB works fine.

any idea what i might be doing wrong? or is there some type of shared regex object which isn't intended to be used in more than one or two instances?

the url's are a bit more complicated than listed above, which is why I'm using regex matches for the conditions. it's looking like I'll have to do multiple passes, but I don't grasp why I should have to.

thank you.

+2  A: 

Your exception means that urla has a value of None. Since urla's value is determined by the re.search call, it follows that re.search returns None. And this happens when the string doesn't match the pattern.

So basically you should use:

urla = re.search(pattern2, match)
if urla is not None:
    print filename, urla.group(1)

instead of what you have now.

oggy
+2  A: 

The reason for TypeError is that search or match usually return either a MatchObject or a None. Only one of these has a group method. And it's not a None. So you need to do:

url = re.search(pattern2, match)
if url is not None:
    print(filename, url.group(0))

P.S. PEP-8 suggests using 4 spaces for indentation. It's not just an opinion, it's a good practice. Your code is fairly hard to read.

SilentGhost
ah. thank you. i use tabs in the code, which got reformatted / reinterpreted by the formatting engine for this site."url is not None fixed it"
ives
A: 

Please also note your mistaken assumption that the error was in the third match, when it was in fact in the second. This seems to have led to the mistaken assumption that the second match was doing something to invalidate the third, sending you way off track.