On String creation for queries in Hibernate and whether those queries would reduce object creation if they were final static

Question

Given this Hibernate snippet

@org.hibernate.annotations.NamedQueries({
    @org.hibernate.annotations.NamedQuery(
        name = "ASSIGNED_CONTINGENCIES",
        query = "select ctg.id from Cont ctg join ctg.labels cl where cl.id = :label_id and ctg.datasetId = tscommon.rdsidtodsid(:datasetting_id)...."
    )
})

Does it mean that everytime I execute this, is the "query" string being created every time or is this a case of string internment? Would it be beneficial to have query in a final static String QUERY and then use it in the @NamedQuery? Would the same be also valid for "name" then?

Answer 1

The String is a String literal, and so is always going to be interned when the class is loaded.

Answer 2

There is no performance or memory benefit, but it might be useful to use constants for the query names to avoid typographic errors, as in this example:

// Entity class
@NamedQueries({@NamedQuery(name=MyBean.FIND_BY_ID, query="select o from MyBean o where o.id = :id")})
public class MyBean {
    public static final String FIND_BY_ID = "MyBean.findById";
}

// Controller/Service/Factory/whatever
em.createNamedQuery(MyBean.FIND_BY_ID).setParameter("id", id).getSingleResult();