python/django for loop creating database populated with 0000-9999

Question

Basically, i've created a view to populate my database with Serial models from 0000 to 9999. below is the code i'm using for the view.

def insert_serials(request):
    for i in range(0,10000):
    serial = Serial(i,False)
    serial.save()
    else:
    print 'The for loop is over'

what is the right way to do this, and i'm getting an IntegrityError, duplicate keys, my model defination is below:

class Serial(models.Model):
    serial = models.CharField(max_length=4)
    closed = models.BooleanField()

    def __unicode__(self):
        return "%s" %(self.serial)

    def get_absolute_url(self):
        return "/draw/serial/%s/" % (self.serial)

Answer 1

Try adding unique=False in the closed field declaration.

Also, you're trying to put integers into a string field. You should do it like Serial('%04d' % i, False) to put values from '0000' to '9999'.

Answer 2

There may be positional default arguments, try using keywords:

from django.db import transaction

@transaction.commit_manually
def insert_serials(request):
    for i in range(0,10000):
        serial = Serial(serial=str(i),closed=False)
        serial.save()
    transaction.commit()
    print 'The for loop is over'

It's wrapped in a transaction should speed it up a bit. See transaction.commit_manually for details

Answer 3

Your code is working on my site - Mac OS X, Python 2.6.3, django from trunk, sqlite3

I changed your view function code a bit, though -

from django.http import HttpResponse
from models import Serial

def insert_serials(request):
    for i in range(0,10000):
        serial = Serial(i,False)
        serial.save()
    return HttpResponse("Serials are inserted")

Answer 4

Your id field (implied by the absence of a PK definition in your model) is not being autonumbered correctly and therefore every INSERT after the first is failing with a duplicate id value. What's your database? Did you have Django create the table, or did you do it yourself?