tags:

views:

1022

answers:

6

I'm relatively new to C. I've come across a form of function syntax I've never seen before, where the parameter types are defined after that parameter list. Can someone explain to me how it is different than the typical C function syntax?

Example:

int main (argc, argv)
int argc;
char *argv[];
{
return(0);
}
+7  A: 

That's the old-style syntax for parameter lists, which is still supported. In K&R C you could also leave off the type declarations and they would default to int. i.e.

main(argc, argv)
char *argv[];
{
    return 0;
}

would be the same function.

Ferruccio
AndreyT
+1  A: 

There is no difference, it is just that that is the old syntax for function declarations in C -- it was used pre ANSI. Never write such code unless you plan to give it to your friends from the 80's. Also, never depend upon implicit type assumptions (as another answer seems to suggest)

Aviral Dasgupta
Well pre C99; it was used pre-ANSI, which was standardized in 1989 but the process began in 1983.
Brian Campbell
Thanks mate. Fixed it now...
Aviral Dasgupta
AndreyT
Amidst the criticism, I must say I agree with you: don't do it.
BobbyShaftoe
A: 

Its just the same but old fashion. You probably found it is some old, legacy code.

eyalm
+2  A: 

While the old syntax for function definition still works (with warnings, if you ask your compiler), using them does not provide function prototypes.
Without function prototypes the compiler will not check if the functions are called correctly.

#include <stdio.h>
int foo(c)
int c;
{ return printf("%d\n", c); }

int bar(x)
double x;
{ return printf("%f\n", x); }

int main(void)
{
    foo(42); /* ok */
    bar(42); /* oops ... 42 here is an `int`, but `bar()` "expects" a `double` */
    return 0;
}

When the program is run, the output on my machine is

$ gcc proto.c
$ gcc -Wstrict-prototypes proto.c
proto.c:4: warning: function declaration isn’t a prototype
proto.c:10: warning: function declaration isn’t a prototype
$ ./a.out
42
0.000000
pmg
+4  A: 

This is so caller K&R style or old-style declaration. Note, that this declaration is significantly different from the modern declaration. K&R declaration does not introuce a prototype for the function, meaning that it doesn't expose the types of the parameters to the outside code.

AndreyT
+2  A: 

What's also interesting is the calling convention difference of functions with, and functions without a prototype. Consider an old style definition:

void f(a)
 float a; {
 /* ... */
}

In this case, the calling convention is that all arguments are promoted before being passed to the function. So f receives a double, but the parameter has type float, which is perfectly valid. The compiler has to emit code that converts the double back to a float prior to executing the function's body.

If you include a prototype, the compiler does not do such automatic promotions anymore, and data is passed as being converted to the types of the parameters of the prototypes as if by assignment. So the following is not legal and results in undefined behavior:

void f(float a);
void f(a)
  float a; {

}

In this case, the function's definition would convert the submitted parameter from double (the promoted form) to float because the definition is old-style. But the parameter was submitted as a float, because the function has a prototype. Your options of solving the contradictions are the two following

// option 1
void f(double a);
void f(a)
  float a; {

}

// option 2
// this declaration can be put in a header, but is redundant in this case, 
// since the definition exposes a prototype already if both appear in a 
// TU prior to the call. 
void f(float a); 

void f(float a) {

}

Option 2 should be preferred if you have the choice, because it gets rid of the old style definition up front. If such contradicting function types for a function appears in the same translation unit, the compiler will usually tell you (but is not required). If such contradictions appear over multiple translation units, the error will go most possibly unnoticed and can result in hard to predict bugs. Best is to avoid these old style definitions.

Johannes Schaub - litb