double qoutes in variables causing javascript error

Question

In my below code when the $artist or $title variables contain " it causes the JavaScript command to break.

Is there another way I can encode these other than addslashes() to fix this?

$artist = addslashes($row['artist']);
 $title = addslashes($row['title']);

 echo '<div class="play" style="display: inline"><a href="javascript:playSong'."('$artist','$title','$row[file]','$row[id]')".'">

Answer 1

You could try urlencode().

Answer 2

you can consider url encoding for variables, like

$artist = rawurlencode($row['artist']);
$title = rawurlencode($row['title']);

echo "..... playSong(unescape('$artist'), unescape('$title')... ";

or move decoding into playSong function.

// edit: this is how you get your quotes right

echo "<div class='play' style='display: inline'><a href=\"javascript:playSong(unescape('$artist'),unescape('$title'),'$row[file]','$row[id]')\">....";

Answer 3

Try this

echo '<div class="play" style="display: inline"> <a href="javascript:playSong('$artist','$title','$row[file]','$row[id]')" >'