tags:

views:

985

answers:

5

Hi,

I need to find smallest and second smallest number in a list.

Can I do this using single loop? Also, we need to consider the case of two multiple occurences of a number.

Ex: 1. from list [20,30,90,50] output 20 ,30 2. from list [30,30,90,50] output 30 ,30

plz help

+6  A: 

I want to encourage you to do your homework on your own and understand the concepts behind it, so I won't post any code for you, but here are some things to guide you:

  • It is possible to do this with only one loop.
  • Make one pass through the list, all the time saving the current smallest and second-smallest number. These are the smallest and second-smallest up until this point in the list.
  • At the end, you'll notice (if you've done it correctly) that you have the smallest and second-smallest numbers.
  • In the case of a duplicate number, just be sure to include an equals check in the condition you use; i.e., you'll be checking for smaller values, so use i <= smallest and i <= secondSmallest as your two conditions (as opposed to a strict smaller than comparison).
Josh Leitzel
Hi Josh Leitzel, I agree with you. But I am in little hurry. Thanks.
abhishek
We dish out information. We're not here to compensate for your poor planning.
Carl Smotricz
@abishek: That's no excuse really. Josh has given you a high level description of what to do - it shouldn't take you very long to convert that into code.
Jon Skeet
Sorry, but I won't post the code for you. I've basically described the algorithm for you in words, which should make it very easy for you to write the corresponding Java. If you're interested in just grabbing the code and turning it in, then I'm sure you can find something with a quick Google search as this is a common elementary programming algorithm. But I think it's important that you try to grasp the concepts, as this kind of problem-solving thinking is incredibly important.
Josh Leitzel
@Tony - To be frank I am in parallel working on it.And I got the solution myself.Thanks
abhishek
Good description on what to do.
Thorbjørn Ravn Andersen
A: 

Call Collections.min(), then remove the element you got from the List, and call it again?

    List<Integer> list = Arrays.asList(20, 30, 90, 50);
    List<Integer> copy = new ArrayList<Integer>(list);
    Integer smallest = Collections.min(copy); // 20
    copy.remove(smallest);
    Integer secondSmallest = Collections.min(copy); // 30

(Making a copy not to mess with the original.)

This is probably far from the most performant solution (From Collections.min() Javadoc: "This method iterates over the entire collection, hence it requires time proportional to the size of the collection."), but it's very simple to write and maintain. :)

Jonik
That would work, but it doesn't sound like it would meet the requirements of the assignment. For one thing, the loops would be implicit. And there would in effect be two loops running in sequence.
Carl Smotricz
Heh, I don't know about any assignments. This meets the spec of finding two smallest (even with duplicates), and no-one said it wouldn't be ok to *use the libraries* ;-) (http://stackoverflow.com/questions/822768/what-are-the-pitfalls-of-a-java-noob/826344#826344)
Jonik
The question does mention *single loop* though, so we could argue about that part of course. :) This solution itself uses *zero* loops, obviously, although under the hood probably 3 are involved (one for making the copy). In any case, I think this approach should be mentioned too.
Jonik
Well, right, perhaps this is a bit silly answer to that q. Still, in the real world, you should start optimising this kind of stuff only *after* your profiler shows that there's a real performance bottleneck there (assuming you're not writing a library or something).
Jonik
More downvotes please! :P If I'm going to delete this, I might just as well get the Peer Pressure tag for it. ;)
Jonik
A: 

Arrays.sort() or Collections.sort() and the take two smallest elements.

Peter Lawrey
Bleah. A good example of how NOT to do it.
J S
Would you answer the same thing if your array had 100,000,000 elements ?
Amadeus45
@Amadeus45 Isn't Peter's approach and the one I outlined in my answer basically the same, efficacy-wise? Either way it's O(n) for mine, and possibly O(n log n) for Peter's, so one might argue that his is technically the better approach. Nevertheless it's not what the OP was after, as his was clearly a homework question.
Josh Leitzel
Definitively O(n log n) for Arrays.sort.
Thorbjørn Ravn Andersen
@J S: Can you add substance, why ? What you suggest in case we have a scenario mentioned by Amadeus45.
Nrj
A: 

I am sorry, Actually I dont have list of Integers. But I ahve list of objects.

Anyways, thanks for the help. I hope the following code works

if (minimum==0 || obj.getValue() < minimum) {
    second = minimum;
    minimum= obj.getValue();
} else if (obj.getValue() < second || second==0) {
    second = obj.getValue();
}
abhishek
Objects don't have "<" and ">", those only work for numbers. But you can use compareTo(). Here's the API for Comparable: <http://java.sun.com/j2se/1.4.2/docs/api/java/lang/Comparable.html>
Carl Smotricz
but obj.getvalue returns integer
abhishek
Oh, you have a certain kind of object. OK then. What will your algorithm do if there is a 0 in the list?
Carl Smotricz
:)there wont be a zero in the list..this is list of time taken by students to solve a problem.I dont think anyone would solve it in zero sec's. :)
abhishek
@abhishek: You never know, they might be in a hurry too.
Troubadour
A: 

Pseudocode only since it's homework, to be turned into your language of choice. Assuming the list has two or more numbers in it (indexes 0 and 1):

set lowest to value at index 0.
set second_lowest to value at index 1.
if lowest is greater than second_lowest:
    swap lowest and second_lowest.
vary idx from 3 to last element:
    if value at index idx is less than lowest:
        set second_lowest to lowest
        set lowest to value at index idx
    else
        if value at index idx is less than second_lowest:
            set second_lowest to value at index idx

This works by basically checking every number to see if it should be the new lowest or new second lowest number. It can be done in one loop.

What you want to do is to run this program in your head, writing down on paper what the variables get changed to. That's a good way to understand how a computer works. Consider the list [30,20,90,10,50,12,7], following the following steps:

lowest   second   description
------   ------   -----------
    30       20   store first two elements.
    20       30   swap them if in wrong order (they are).
    20       30   90 is not less than either so ignore.
    10       20   10 is less than lowest (20) so move
                  lowest to second, store 10 to lowest.
    10       20   50 is not less than either so ignore.
    10       12   12 is less than second (20) so
                  store 12 to second.
     7       10   7 is less than lowest (10) so move
                  lowest to second, store 7 to lowest.
paxdiablo