views:

527

answers:

7

I'm working on an app in CodeIgniter, and I want to have admin pages for several of the objects in the application, and I'm wondering what would be the better way to put these into an MVC structure.

Idea 1: In each controller, have an admin function, and add all of the admin pages I would like into that function. example URL: domain.com/articles/admin

Idea 2 Make a new admin controller, which would have to reference many different models, and put all of the admin pages in there. example URL: domain.com/admin/articles

which way would be better?

edit for clarification: By admin functionality, I mean being able to do the basic CRUD actions on any object, and be able to display a list of all of said object.

+1  A: 

Depending on what you mean by 'Admin' functionality...typically, this is thought of as an 'Edit' view.

And typically, you use the existing controller to serve the 'Edit' view allowing the authorized users to make the edits (in your case, Admin users only).

Justin Niessner
A: 

Looks like a personal choice, i love having everything centralized so the admin controller would be my bet.

That way i wouldn't have to open up 5 different controllers while modifying admin tasks.

pablasso
This does not expand well. the problem here is that you are munging together lots of unrelated code. Each time the PHP engine runs over the controller it has to compile EVERYTHING in your backend and not just the stuff relevant to the action.
Phil Sturgeon
I can argue the contrary. Admin areas are not traffic intensive, user pages are, and if you're munging together an admin area for every section, the engine has to run over every admin code which is totally irrelevant to the user, hence a waste. Still, this does not really matters with the use of code cachers.
pablasso
+2  A: 

It's a good idea to have an admin folder in the controllers folder wherein you can access your administration e.g. yoursite.com/admin/users.

All your administrative needs will be there and all methods will be protected by checking user privileges like so:

if ( ! $this->auth->logged_in(array('login', 'admin')))
{
    $this->session->set_flashdata('message', 'You do not have access to view this page');

    redirect('admin/users/login');
}

Then all controllers outside the 'admin' folder will - depending on your type of site - will only be for viewing, etc.. no administrative portions.

Thorpe Obazee
You do this in every method? You should do this in the constructor of the controller, or of a base controller to save repetition. http://philsturgeon.co.uk/news/2010/02/CodeIgniter-Base-Classes-Keeping-it-DRY
Phil Sturgeon
+1  A: 

I'll echo Justin in keeping it part of the individual controllers.

You should setup some kind of authorization system that the individual controllers can use to so who is logged in (username) and what access they have (admin/member/etc). Here's a SO thread on CodeIgniter Auth Classes.

The view would then conditionally show the appropriate links, and the controller would enforce the policy by checking the auth before passing any data to the model or rendering an edit view. On unauthorized access an error could be rendered, or simply render with the non-editing view.

This approach seems to make the most sense (at least to me) because all the functionality is stored in the individual controller. Keeping admin functions in a single admin controller means you'll have to manage two controllers (the admin, and the actual controller) every time you add somethign new (or remove something).

If you're concerned about putting auth checking in every controller, you could create a generic controller class with all the auth setup, then have your controllers extend it. In the end the individual controller auth check could be as simple as:

function edit()
{
    if(!$this->auth()){
        //display auth error, or forward to view page
    }
}

Of course some kind of ACL implementation would make this better, but I don't believe CodeIgniter has an 'official' ACL.

Tim Lytle
Out of the handful of downvotes - anyone care to explain why?
Tim Lytle
+4  A: 

Definitely a different controller at least!

I used to think that I could keep all my admin functions in a single controller, but as my programs grew, I realized that I needed multiple controllers in my administration section.

So, I created a folder inside my controllers folder with the name "admin" and put all my administrative controllers in there. So my folders would look something like:

  • application
    • controllers
      • front.php
      • welcome.php
      • admin
        • dashboard.php
        • useradmin.php
  • etc...

One problem this creates, however, is when you type http://mysite.com/admin in your browser, it returns a 404 page. So, go to your "application/config/routes.php" file and add a custom route:

$routes['admin'] = 'admin/dashboard/index';
caseyamcl
+1  A: 

Idea 2 is better. system/application/controllers/admin

You keep all your admin controllers here.

shin
A: 

Here is an extensive guide to the pro's and con's of each method:

http://philsturgeon.co.uk/news/2009/07/Create-an-Admin-panel-with-CodeIgniter

Phil Sturgeon