Django Filtering Problem

Question

I'm trying to set up a filter query in one of my views...basically my code looks as below:

def inventory(request):   
   vehicle = Vehicle.objects.all().exclude(status__status='Incoming').order_by('common_vehicle__series__model__manufacturer__manufacturer', 'common_vehicle__series__model__model', 'common_vehicle__year')

   year_count = Vehicle.objects.exclude(status__status='Incoming').order_by('-common_vehicle__year__year').values('common_vehicle__year__year').annotate(count=Count('id'))
   make_count = Vehicle.objects.exclude(status__status='Incoming').order_by('common_vehicle__series__model__manufacturer__manufacturer').values('common_vehicle__series__model__manufacturer__manufacturer').annotate(count=Count('id'))

   return render_to_response('vehicles.html', {'vehicle': vehicle, 'make_count': make_count, 'year_count': year_count,})

def year_filter(request, year):
   vehicle = Vehicle.objects.filter(common_vehicle__year__year=year)

   return render_to_response('filter.html', {'vehicle':vehicle,})

def make_filter(request, make):
   vehicle = Vehicle.objects.filter(common_vehicle__series__model__manufacturer__manufacturer=make).exclude(status__status='Incoming')

   return render_to_response('filter.html', {'vehicle':vehicle,})

So far when I try any of the last two views, I'm only getting the query set from the first view i.e. inventory. The URLConf file looks as below:

(r'^inventory/year/(?P<year>d{4})/?$', 'app.vehicles.views.year_filter'),
(r'^inventory/make/(?P<make>)/', 'app.vehicles.views.make_filter'),

Answer 1

It looks like in your URLConf, above the ones you have already mentioned, you might have a mapping which overrides the ones below - say like -

(r'^inventory/', 'app.vehicles.views.inventory'),

which is causing all the calls in inventory to hit the method inventory.

This is because Django goes through it in a serial fashion. Any URL which matches it first will hit it. To overcome this, you reorder the urls in the following way -

(r'^inventory/year/(?P<year>d{4})/?$', 'app.vehicles.views.year_filter'),
(r'^inventory/make/(?P<make>)/', 'app.vehicles.views.make_filter'),
(r'^inventory/', 'app.vehicles.views.inventory'),

Answer 2

Koran is on the right path. Try having this in your URLconf:

(r'^inventory/$', 'app.vehicles.views.inventory'),
(r'^inventory/year/(?P<year>d{4})/?$', 'app.vehicles.views.year_filter'),
(r'^inventory/make/(?P<make>)/', 'app.vehicles.views.make_filter'),

The regex r'^inventory/$' matches strictly just that, nothing past the '/'. This should cause the other URLs to map to the proper views.

Answer 3

It looks to me like you're missing an expression.

(r'^inventory/year/(?P<year>d{4})/?$', 'app.vehicles.views.year_filter'),
(r'^inventory/make/(?P<make>)/', 'app.vehicles.views.make_filter'),

<year> matches a series of 4 digits, what does <make> match?

(r'^inventory/make/(?P<make>[-\w]+)/', 'app.vehicles.views.make_filter'),

That matches something to the make variable. Happy to know if I'm wrong!

Answer 4

d{4} always matches exactly four d's, dddd. Is that what you want?

(r'^inventory/year/(?P<year>d{4})/?$', 'app.vehicles.views.year_filter'),

I suspect you need to escape d with \, compare:

(r'^inventory/year/(?P<year>\d{4})/?$', 'app.vehicles.views.year_filter'),