Troubles formatting if statements in SQL

Question

I've created the following sql statement, every thing in $() is a variable (comes from the module we're using on our site so $(varname) is the right format in this case, not @varname.

It keeps telling me there's an error near THEN... how am I supposed to format this properly?

IF ($(Shiptobilling) = 'yes') THEN
    BEGIN
        CardOrder_Add $(UserID), $(Firstname), $(Lastname), $(BillStreet1), $(BillCity), $(BillState), $(BillCountry), $(BillZip), getdate(), $(ExpiryDate)
    END
ELSE
    BEGIN
        CardOrder_Add $(UserID), $(Firstname), $(Lastname), $(ShipStreet1), $(ShipCity), $(ShipState), $(ShipCountry), $(ShipZip), getdate(), $(ExpiryDate) 
    END

Thanks,
Matt

Answer 1

Get rid of the THEN, and add EXEC before your stored procedure calls.

IF ($(Shiptobilling) = 'yes') 
BEGIN
EXEC CardOrder_Add $(UserID), $(Firstname), $(Lastname), $(BillStreet1), $(BillCity), $(BillState), $(BillCountry), $(BillZip), getdate(), $(ExpiryDate)
END
ELSE
BEGIN
EXEC CardOrder_Add $(UserID), $(Firstname), $(Lastname), $(ShipStreet1), $(ShipCity), $(ShipState), $(ShipCountry), $(ShipZip), getdate(), $(ExpiryDate) 
END

Also, you should use some better indentation. If this were my code I'd format it more like this:

IF ($(Shiptobilling) = 'yes') 
  BEGIN
  EXEC CardOrder_Add 
    $(UserID), 
    $(Firstname), 
    $(Lastname), 
    $(BillStreet1), 
    $(BillCity), 
    $(BillState), 
    $(BillCountry), 
    $(BillZip), 
    getdate(), 
    $(ExpiryDate)
  END
ELSE
  BEGIN
  EXEC CardOrder_Add 
    $(UserID), 
    $(Firstname), 
    $(Lastname), 
    $(ShipStreet1), 
    $(ShipCity), 
    $(ShipState), 
    $(ShipCountry), 
    $(ShipZip), 
    getdate(), 
    $(ExpiryDate) 
  END

It's pretty long, but then again it's easy to maintain because you don't have to scroll left and right to see the entire procedure call.

Answer 2

There is no Then in t-sql if statments

Answer 3

As well as the extra "Then" as others have mentioned, you will need to add exec before the stored procedure calls within the body of the if statements.