views:

273

answers:

3

This is my simple Django database model. It's for a 5-star rating system.

class Rating(models.Model):
    content = models.OneToOneField(Content, primary_key=True)
    ip =  models.CharField(max_length=200, blank=True)
    rating = models.IntegerField(default=0)

As you can see, it is linked to "Content", which is the table for my documents. My question is:

  • How do I make content+ip unique...so that it multiple content is okay, but multiple content AND IP is not okay (do not want the user to rate twice).
  • How do I create a data-base index for content and ip...because I will always be selecting those (to compare if it is already in the database).
+10  A: 

Regarding your first question: You should look at unique_together.

class Rating(models.Model):
    content = models.OneToOneField(Content, primary_key=True)
    ip =  models.CharField(max_length=200, blank=True)
    rating = models.IntegerField(default=0)

    Class Meta:
        unique_together= (('content', 'ip'),)
ikkebr
it might be better to convert the IP into an `int` before storing, and use an `IntegerField`. it will use less space (im not sure why you've allocated 200 bytes to an IP address), and allow more query flexibility. you may also want to check out `django-ratings` (http://github.com/dcramer/django-ratings), which handles both anonymous and authenticated votes very well.
Carson
+3  A: 

About the indexes: you don't need to do anything for content, since it is a primary key, it will be indexed. For ip, just add index=True to the CharField constructor call:

ip = models.CharField(max_length=200, blank=True, index=True)
Ned Batchelder
Indexing a second field will not make that field unique with the primary key.
hughdbrown
I wasn't answering the question about uniques. The second bullet in the question asks about indexing ip.
Ned Batchelder
+5  A: 

BTW, if, as it appears from your terminology, you're using IP addresses as standing for users' identities, please don't -- it's a seriously horrible idea. Users coming in through their ISP will get their IPs changed at random times, so they might vote twice; users on a laptop connecting at various coffee shops, libraries, &c, will have always-varying IPs; users sharing a connection (e.g., apartment-mates), or even every single one of users coming in from a University campus, might get the same IP address via NAT, so only one will be able to vote... it's hard to think of any worse way to represent individuals' identities!-)

If your use of the name ip for your "user identity" field is accidental and has nothing to do with using IP addresses there, I apologize, but in that case please do rename that field!-)

Alex Martelli