views:

370

answers:

4

According to Swing tutorial:

Some Swing component methods are labelled "thread safe" in the API specification; these can be safely invoked from any thread. All other Swing component methods must be invoked from the event dispatch thread. Programs that ignore this rule may function correctly most of the time, but are subject to unpredictable errors that are difficult to reproduce.

But what are these Swing component methods that are labelled "thread safe"? Are there actually any?


Update / bounty:

Is there a complete list of thread-safe swing methods? (The thread-safe Swing methods seems to be quite rare, so such list can't be too long...)

+6  A: 

Google learns me that at least those are threadsafe.

BalusC
Thanks, I should learn to construct better non-trivial (?) Google queries :-)
Joonas Pulakka
You're welcome. Here's an useful link anyway: http://www.googleguide.com/using_advanced_operators.html
BalusC
+3  A: 

But you already have the answer: only those methods which are specifically documented as being thread-safe in the method JavaDoc, are threadsafe! this is from JTextComponent.setText

 * This method is thread safe, although most Swing methods
 * are not. Please see 
 * <A HREF="http://java.sun.com/docs/books/tutorial/uiswing/misc/threads.html"&gt;How
 * to Use Threads</A> for more information.

If the method documentation doesn't say it's safe, then it isn't safe: access to the JavaDoc is therefore critical when coding against Swing

oxbow_lakes
Yes, it's the implicit answer, but it still isn't a list of thread safe methods.
Joonas Pulakka
You asked "are there any" and I provided an example. Um.
oxbow_lakes
+5  A: 

But what are these Swing component methods that are labelled "thread safe"?

Most Swing components' methods are NOT thread safe. But some are. To find out which ones, you have no option but to peruse the javadocs for your target components. A carefully constructed google search might quicken the process.

Are there actually any?

Yes there are indeed. Generally speaking, if you are working with Swing components, it is likely that you are going to have to invoke both thread-safe and non-thread-safe methods. Since most methods are non-thread-safe, I prefer to err on the side of caution, and perform all actions on them in a thread-safe manner anyway.

HTH


Not exhaustive list.

DefaultStyledDocument:

  • protected void insert(int offset, DefaultStyledDocument.ElementSpec[] data) throws BadLocationException
  • public void setLogicalStyle(int pos, Style s)
  • public void setCharacterAttributes(int offset, int length, AttributeSet s, boolean replace)
  • public void setParagraphAttributes(int offset, int length, AttributeSet s, boolean replace)

javax.swing.text.AbstractDocument:

  • public void render(Runnable r)
  • public void remove(int offs, int len) throws BadLocationException
  • public void insertString(int offs, String str, AttributeSet a) throws BadLocationException
  • public Position createPosition(int offs) throws BadLocationException

javax.swing.undo.UndoManager:
Class is threadsafe

bguiz
You stole my link.
BalusC
@BalusC Did not! Consider the fact that it takes a couple of minutes to type an answer before you jump to conclusions.
bguiz
+2  A: 

For a list of classes with the comment in the javadocs & src files "is thread safe" returns the following

JEditorPane
JTextArea
AbstractDocument
DefaultCaret
DefaultStyledDocument
JTextComponent    
PlainDocument
StyleContext    
HTMLDocument
UndoManager

This is not saying that there are others documented or undocumented within the src that are thread safe.

It strikes me as a rather strange question but I would treat most components as not being threadsafe and since Swing is a single threaded model and all updates need to happen on the event dispatcher thread this is pretty easy to do.

Shawn