tags:

views:

116

answers:

4
Q: 

What's wrong with this Javascript Code?

I believe something on this code chunk is not properly coded making it incompatible on XHTML 1.0 Transitional.

The code snippet collapses div and then on click they will expand.

Can somebody see what could be wrong?

<script type="text/javascript">

function toggle(div){
el = document.getElementById(div);
    if (el.style.display == 'none')
    {
        el.style.display = '';
    } else {
        el.style.display = 'none';
    }
}

</script>

I have this before the <BODY> tag. If I remove the DOCTYPE another menu I have stops working but then the rows expand by default and aren't collapsed.

A: 

Instead of el.style.display = ''; try el.style.display = 'block';.

Topher Fangio  2010-01-08 21:46:09
that would be worse. `display=''` nicely reverts to default, which may need to be `table-row`, `inline`, etc.
porneL  2010-01-08 21:47:29
@porneL - Does it revert to the default on all browsers?
Topher Fangio  2010-01-08 21:50:35
Yes. Perfectly in all cases. `.style` is just convenient interface to HTML `style` attribute. It's not a actual computed style of the element, so there's no harm in removing _the override_ (just like there is no harm in removing `style` attribute from HTML).
porneL  2010-01-08 21:53:05
A: 

You shouldn't set the style.display = '', but rather set it to 'block', 'inline' or 'table-row'.

Shawn Steward  2010-01-08 21:46:15
or use table-row
darren  2010-01-08 21:49:53
@darren - Thanks, updated my answer.
Shawn Steward  2010-01-08 22:01:31
+2  A: 
  1. You should check if passed argument is valid (e.g. not undefined, empty string, etc.).
  2. You should check if document.getElementById(div) found the element (e.g. even valid name will not work while document is loading and <script> is earlier in the source than element you're referring to).
  3. You're creating global variable el (put var in front of assignment).
  4. W3C recommends Transitional DTD should be avoided whenever possible, and today it is possible not to use <font> and bgcolor. Use XHTML Strict, unless you don't know what a MIME type is, then use HTML5.
porneL  2010-01-08 21:49:43
A: 

It ended up being a problem with a simple display css attribute on the div. There was a markup error.

Codex73  2010-01-08 22:22:32

related questions

Autosizing Textarea
Regular expression for parsing links from a webpage?
What are good tools for creating compiled HTML help files (.chm)?
Looking for WYSIWYG HTML editor
Any reason not to start using the HTML 5 doctype?
HTML comments break down
HTML Comments Markup
Setting a div's height in HTML with CSS
Wrapping lists into columns
Is a "Confirm Email" input good practice when user changes email address?
<XMP> Tag
HTML version choice
Options for HTML scraping?
How do you disable browser Autocomplete on web form field / input tag?
How do I make a checkbox toggle from clicking on the text label as well?
Html CSS Editor
Wordpress theme development offline tools
How do I give my web sites an icon for iPhone?
In HTML, how to word-break on a dash?
Detecting font in JavaScript
How do you test layout design across multiple browsers/OSs?
How do I print an HTML document from a web service?
Multiple submit buttons on a HTML form
How can I determine a web user's time zone?
Why doesn't the percentage width child in absolutely positioned parent work in IE7?