views:

265

answers:

4

I am having trouble finding the correct refactor option for the following scenario:

I have code like this (in Outer.java):

public class Outer {

    // ... class stuff

    public static class Inner {
        // ... inner class stuff   
    }
}

I am looking for a way to select Inner, and have it converted to a top level class, in it's own .java source file. I know this is pretty easy to do manually with copy/paste etc., but the inner class is referenced in a lot of places, and I would like the refactor option to handle the change everywhere it is referenced.

I have tried the option Refactor -> Extract Class... but that does something weird with a field called data that I don't quite understand.

Eclipse version is 3.5.1 Galileo.

How do I refactor a static inner class to be a top level class?


Edit: Can't believe I overlooked the option to do this. Thanks for all your correct answers, +1 to you all. I'll still need to accept an answer, so if there is any more useful info, e.g. gotchas with the script, there is still a purpose to leaving an answer.

+4  A: 

This is so easy I can't believe I missed it:

With the cursor anywhere within the inner type, right click and select:
Refactor -> Convert Member Type to Top Level...

(There is no shortcut in the default settings)

This automatically extracts the inner type, and places it in it's own file, in the same package and directory as the outer type.

Grundlefleck
+1  A: 

I have 3.4.1, and if I right-click on Inner, >refactor, I have the option "Covert member Type to top level..", which does exactly what you want.

EJB
+2  A: 

Use Refactor -> Convert Member to Top Level Type

Klarth
+2  A: 

Extract Class is not what you want.

I just did this using Eclipse 3.4.2

  1. Select Inner
  2. Right click 'Refactor->Convert Member Type To Top Level...'
Kelly French