views:

26738

answers:

6

What's the best way to pipe the output from an java.io.OutputStream to a String in Java?

Say I have the method:

  writeToStream(Object o, OutputStream out)

Which writes certain data from the object to the given stream. However, I want to get this output into a String as easily as possible.

I'm considering writing a class like this (untested):

class StringOutputStream extends OutputStream {

  StringBuilder mBuf;

  public void write(int byte) throws IOException {
    mBuf.append((char) byte);
  }

  public String getString() {
    return mBuf.toString();
  }
}

But is there a better way? I only want to run a test!

+24  A: 

I would use a ByteArrayOutputStream. And on finish you can call:

new String( baos.toByteArray(), codepage );

or better

baos.toString( codepage );
Horcrux7
ByteArrayOutputStream has no toArray() method; it does have toByteArray() though. Can you fix the answer? Also, why not use baos.toString(String charsetName) which would be slightly simpler.
Jonik
Thanks for the tip with the toString(charset). I have never look on the toString because I have expect a ByteArrayOutputStream@123456. I have also correct the mistake with toByteArray().
Horcrux7
Also note that some codepages are not installed unless you explicitly ask for them with a custom install.
Thorbjørn Ravn Andersen
can return simply baos.toString(), what is the coepage thing for?
Tom Brito
+2  A: 

I like the Apache Commons IO library. Take a look at its version of ByteArrayOutputStream, which has a toString(String enc) method as well as toByteArray() . Using existing and trusted components like the Commons project lets your code be smaller and easier to extend and repurpose. Good luck.

Joe Liversedge
Save yourself a year of your life and read through all the common's APIs so when you encounter a problem, you can unleash a fully tested and community owned solution.
Bob Herrmann
Hmm, I'm an avid Apache Commons user, but in this case I fail to see why you should use Commons IO's ByteArrayOutputStream instead of JDK's own java.io.ByteArrayOutputStream. The latter also provides toString(String charsetName) and toByteArray() methods. Care to elaborate?
Jonik
Yeah, since the original context was a better way to stream and extract content, I included the Commons IO example since it included a 'write(InputStream)' method for a then-undefined/questionable mechanism for populating the OutputStream. I'd go with the JDK, too.
Joe Liversedge
A: 

Here's what I ended up doing:

Obj.writeToStream(toWrite, os);
try {
    String out = new String(os.toByteArray(), "UTF-8");
    assertTrue(out.contains("testString"));
} catch (UnsupportedEncondingException e) {
    fail("Caught exception: " + e.getMessage());
}

Where os is a ByteArrayOutputStream.

Adrian Mouat
what is 'os' in your code?
Synox
A: 

From what you describe I would suggest having a look at java.io.StringWriter. It collects in a StringBuffer which you can then convert to a String when you need it.

http://java.sun.com/j2se/1.5.0/docs/api/java/io/StringWriter.html

Thorbjørn Ravn Andersen
Writers require char data, not bytes as the question has, which would require some intermediate decoding.
McDowell
You are right - somehow I mixed Writers/Streams up while checking. For OutputStreams the usual trick is to use a ByteArrayOutputStream.
Thorbjørn Ravn Andersen
+2  A: 

this worked nicely

    OutputStream output = new OutputStream()
    {
        private StringBuilder string = new StringBuilder();
        @Override
        public void write(int b) throws IOException {
            this.string.append((char) b );
        }

        //Netbeans IDE automatically overrides this toString()
        public String toString(){
            return this.string.toString();
        }
    };

method call =>> marshaller.marshal( (Object) toWrite , (OutputStream) output);

then to print the string or get it just reference the "output" stream itself As an example, to print the string out to console =>> System.out.println(output);

FYI: my method call marshaller.marshal(Object,Outputstream) is for working with xml. It is irrelevant to this topic.

This is higly wasteful for productional use, there are way to many conversion and it is a bit loose. This was just coded to prove to you that it is totally possible to create a custom OuputStream and output a string. But just go Horcrux7 way and all is good with merely two method calls.

And the world lives on another day....

Just casting a byte to char will only work on ascii. Use ByteArrayOutputStream like Horcrux7
Dave Ray
+1  A: 

@Adrian :

More exactly 'os' is an ByteArrayOutputStream as OutputStream doesn't have a method toByteArray();

I don't know how to reply just under your response to Synox, so I just added an new answer.

++

redsonic
Thanks, I've clarified the answer. You probably couldn't add a comment due to low rep.
Adrian Mouat