Keep all entities in one ejb module

Question

There are few applications that use java persistence. Each application has its own set of entities that represents the same tables in DB. For instance, application A has entities for Table1, Table2, etc; at the same time, application B also has entities for Table1, Table2, etc. Instead of that I want to create a new EJB module with 1 bean with local interface, move all entities into it, and add it as a library to projects that may require access to persistent objects. So, it will look like

@Stateless
public class DataBean implements DataLocal {        
@PersistenceContext(unitName="my_data")
private EntityManager em ;  
public EntityManager getManager()
{
  return em;
};
}

I'm pretty new in Java-ee, so I wonder whether it is a poor design or not. Thanks in advance.

Answer 1

There are few applications that use java persistence.

Are you kidding? :)

Instead of that I want to create a new EJB module with 1 bean with local interface, move all entities into it, and add it as a library to projects that may require access to persistent objects.

Putting Entities in separated JARs is definitely the right approach for reuse and modularity. And to use such packaged entities, use the jar-file element in the persistence.xml to make them visible to the packaged persistence unit of each application needing them.

I'm pretty new in Java-ee, so I wonder whether it is a poor design or not. Thanks in advance.

I don't get the point of the stateless session bean and the getter returning an EntityManager, you don't need that in my opinion.