tags:

views:

97

answers:

2

As a practice exercise, I am trying to get five numbers from a user and return the sum of all five number using a while loop. I managed to gather the five numbers, but the sum is not provided by my code (I get a number, but it is always double the last number). I believe the issue is with my use of +=.

x = 0   
while x < 5:
    x += 1
    s = (int(raw_input("Enter a number: ")))
    s += s
print s
+4  A: 

This should be better.

x = 0
s = 0   
while x < 5:
    x += 1
    s += (int(raw_input("Enter a number: ")))
print s

You were putting one of the results on to the sum of all results and lost the previous ones.

gruszczy
+6  A: 

Gruszczy already solved your main problem, but here is some advice relevant to your code.

First, it's easier to do a for loop rather than keep track of iterations in a while:

s = 0
for i in range(5):
  s += int(raw_input('Enter a number: '))

Second, you can simplify it using the built-in sum function:

s = sum(int(raw_input('Enter a number: ')) for i in range(5))

Third, both of the above will fail if the user enters invalid input. You should add a try block to take care of this:

s = 0
for i in range(5):
  try:
      s += int(raw_input('Enter a number: '))
  except ValueError:
      print 'Invalid input. Counting as a zero.'

Or if you want to force 5 valid numbers:

round = 0
s = 0
while round < 5:
  try:
      s += int(raw_input('Enter a number: '))
  except ValueError:
      print 'Invalid input.'
  else:
      round += 1
Max Shawabkeh