What is the relationship between a code smell and an anti-pattern?

Question

In my mind I think that an anti-pattern is the cause, and a code-smell is just one of man possible symptons. Is this correct?

For example:

• God class antipattern -> large class code smell

• Not Invented Here Antipattern -> code that should not even be there

• Analysis Paralysis anti-pattern -> no code smell results, but leads to bankcruptcy or something else

So, what I am saying is that maybe code-smells are just one of many possible symptons of an anti-pattern, or "bad practice".

Answer 1

It's the same relationship between good style and patterns.

A code smell is just that you've got some bad things in your code.

An anti-pattern is the description of a common source of bad things in your code.

Answer 2

Excessive use of anti-pattern will be code smell.

Answer 3

Maybe antipatterns are bad ideas put into code, while code smells result from having no ideas.

A bad idea, even if carried through with elegant precision would be an antipattern.

I find that code smells often emanate when I don't know how to solve a specific problem in a clear and concise way. Let's say a new function has to be introduced in an exising program, but the architecture of the program doesn't really support the new function. Maybe the new function could be easily implemented if you added a magic widget to every form, and 200 almost identical lines to most of your business classes and a new field to half of your data tables. You know it would work this way, but solving it that way would be SMELLY.

If, however, you got the right idea you could implement the new function in a new layer of your architecture to support the new function without introducing any new smells.

Answer 4

A code smell COULD be an indication of an Anti-Pattern (but doesn't necessarily has to).

Answer 5

An anti-pattern is almost always a bad thing. It's a concrete 'badness' that you can detect.

Code smells were named so because they're like a bad smell in the fridge. Something's probably wrong, but it may not be immediately apparent what the problem is. And sometimes, the food's actually supposed to smell that way.

Anti-patterns should be removed. A code smell is a sign that more investigation is warranted, and may reveal an anti-pattern.

Answer 6

An Anti Pattern:

• is a Design Pattern used in the wrong context
• "is something that looks like a good idea, but which backfires badly when applied" (James O. Coplin)
• tells you how to go from a problem to a bad solution