ansaurus

Question

I'm getting a php warning: cannot modify header information (but I have my include file before the html code!)

Answer 1

A:

Try putting ob_start() function at the top of file where you are getting this error.

Sarfraz 2010-02-27 09:33:00

Answer 2

+2 A:

It can happen for several reasons:

You are sending HTTP headers indirecly, via setcookie() or session_start().

Have a look at your set_lang() function. You can fix it by calling l() before output.
You have whitespace before the PHP open tag or after PHP close tag.
You saved the file in UTF-8, but with BOM. Save it without BOM.

You can always add ob_start(), but this will only bypass the problem.

Sagi 2010-02-27 09:33:28

Answer 3

+1 A:

Setting a cookie requires sending a header, so you cannot call set_lang() once you have output any of the page unless you use the output buffering functions.

Ignacio Vazquez-Abrams 2010-02-27 09:34:17

Answer 4

+2 A:

Your l() function is calling set_lang() the first time it is used, which sets a cookie -- and cookies are sent as HTTP-headers.

I'm guessing, from the look of it, that l() is used to get the translated version of a string -- which means it's probably used from everywhere in your HTML/PHP ; i.e. after the output has begun being sent.

You should call set_lang() at the top of your common.php file -- to make sure the cookie is sent before any HTML content.

In fact, in your case, I would modify the l() function so it only does one thing : return a translated string.

I would put the initialization of your translation system out of l() -- which means initializing it "by hand" at the beginning of your script, yes ; but also means a simpler l() function that will have less work to do.

Pascal MARTIN 2010-02-27 09:35:27

@Pascal MARTIN, thanks for the reply. I changed it to: <?php session_start(); header('Cache-control: private'); // IE 6 FIX function set_lang($lang){ setcookie("lang", $lang, time() + (3600 * 24 * 30)); $_SESSION['lang'] = $lang; } function get_lang(){ if(!empty($_GET['lang'])) return $_GET['lang']; if(!empty($_SESSION['lang'])) return $_SESSION['lang']; if(!empty($_COOKIE['lang'])) return $_COOKIE['lang']; return 'en'; } but still doesn't work.

janoChen 2010-02-27 09:46:30

From the look of this, it seems you declared your functions at the beginning of `index.php`, which is one thing ;; but you didn't call `set_lang()` "by hand" ;; which means that's still the firt call to `l()` that will cause `set_lang()` to be called, and cookies to be sent ;; you should call `set_lang()` from the beginning of your `index.php` file, so the cookie is sent before any output.

Pascal MARTIN 2010-02-27 09:54:53

janoChen you can call l() with empty string right after session_start(), so it will set the headers. another possibility would be to use ob_start(), as already said. Have another look at my answer.

Sagi 2010-02-27 09:55:02

@Pascal MARTIN, please can you give me a code example of what you just suggested?

janoChen 2010-02-27 09:56:08

@janoChen : just after the line that contains `include_once 'common.php';` try calling something like `set_lang(get_lang());` so the cookie is sent right away -- or do as @Sagi suggested in his comment, which should get the same result.

Pascal MARTIN 2010-02-27 10:00:25

@Pascal MARTIN I'm not sure it will work, because he uses static variable in l(), which means that anyway he'll set cookie in first call.

Sagi 2010-02-27 10:02:23

@Sagi : well seen about that static variable ; you're right ! ;;; @janoChen : @Sagi's suggestion is what you should do, then : after `include_once 'common.php';`, call the `l()` function to get a first *(that you won't use)* translation, to initialize it and sent the cookie.

Pascal MARTIN 2010-02-27 10:04:20

@Sagi, so what should I do? I deleted the $string as you suggested in the comment above and the whole code fails. How do you do that?

janoChen 2010-02-27 10:04:43

@janoChen Just call l() after session_start() (in common.php) or after include_once 'common.php' (in index.php).

Sagi 2010-02-27 10:06:59

@Sagi, @Pascal Martin I did this: <?phpinclude_once 'common.php';//translation helper functionfunction l($string){ static $translation; if(!isset($translation)){ $lang = get_lang(); $lang_file = get_lang_file($lang); if($lang_file) set_lang($lang); $translation = include $lang_file; } return $translation[$string];}?>...and still getting the error.

janoChen 2010-02-27 10:44:20

@Pascal Martin I also tried this: <?phpinclude_once 'common.php';l()?><!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN""http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"><html>which solves the problem but now I have this: Notice: Undefined index: in /www/zxq.net/a/l/e/alexchen/htdocs/common.php on line 35

janoChen 2010-02-27 10:52:23

ansaurus

tags:

views:

answers:

I'm getting a php warning: cannot modify header information (but I have my include file before the html code!)

related questions