views:

663

answers:

5

Hello Everybody, I've got a problem:

I'm writing a new WebApp without a Framework.

In my index.php im using: require_once('load.php'); and in * load.php* I'm using require_once('class.php'); to load my class.php.

In my class.php I've got this error:

Fatal error: Using $this when not in object context in class.php on line ... (in this example it would be 11)

An example how my class.php is written:

class foobar {

    public $foo;

    public function __construct() {
        global $foo;

        $this->foo = $foo;
    }

    public function foobarfunc() {
        return $this->foo();
    }

    public function foo() {
        return $this->foo;
    }
}

In my index.php I'm loading maybe foobarfunc() like this:

foobar::foobarfunc();

but can also be

$foobar = new foobar;
$foobar->foobarfunc();

Why is the error coming? Nothing found, never seen before in my other Webapps. Can anyone help me please?

EDIT: THANK YOU EVERYBODY! ALL OF YOU ARE RIGHT :)

+4  A: 

In my index.php I'm loading maybe foobarfunc() like this:

 foobar::foobarfunc();  // Wrong, it is not static method

but can also be

$foobar = new foobar;  // correct
$foobar->foobarfunc();

You can not invoke method this way because it is not static method.

foobar::foobarfunc();

You should instead use:

foobar->foobarfunc();

If however you have created a static method something like:

static $foo; // your top variable set as static

public static function foo() {
    return self::$foo;
}

then you can use this:

foobar::foobarfunc();
Sarfraz
The variables having the same name is not an issue. `$this->foo` is a class member, while `$foo` is just a variable in the function scope (imported from global scope). Function names with the same name as a member are also not an issue.
Gordon
@Gordon: oh, yes you are right, thanks man :)
Sarfraz
You cannot use `$this` in a static method.
Yacoby
It's funny how a completely wrong answer gets upvotes nonetheless. $this is not available in class context. The OP will get the same error from the example above.
Gordon
@Ycaoby, @Gordon: I just copy-pasted his code, did not notice the `$this` keyword in there, fixed any ways thanks.
Sarfraz
@Sarfraz No offense, but it is still wrong. You *can* call an instance method with `::`. It is against `E_STRICT`, but it *does* work as long as the method body does not reference the instance scope, e.g. uses `$this`. Also, `self::foo` will not point to `$this->foo`. It references a class **constant**. Both, `self::foo` and `self::$foo` would raise a Fatal Error.
Gordon
@Gordon: he wants to return public variable set on the top.
Sarfraz
@Sarfraz Yes, I know, which is why I am complaining about your solution. The public member `foo` cannot be called from class scope, unless you either declare it static or make it into a constant.
Gordon
@Gordon: forgot that too :( Thanks
Sarfraz
@Sarfraz okay, maybe I'm too picky today, but this will still raise a fatal as self:foo => constant while self::$foo => static member.
Gordon
@Gordon: you really are, but i have become too missing today :(
Sarfraz
@Sarfraz it's better now. Sorry for pestering you, but as this became the accepted answer, I felt it necessary to point these things out :) Thanks for your patience.
Gordon
@Gordon: I highly appreciate your comment, and guess what your pestering has been really generous for me as i was missing too much. Thanks
Sarfraz
+2  A: 

If you are invoking foobarfunc with resolution scope operator (::), then you are calling it statically, e.g. on the class level instead of the instance level, thus you are using $this when not in object context. $this does not exist in class context.

If you enable E_STRICT, PHP will raise a Notice about this:

Strict Standards: 
Non-static method foobar::foobarfunc() should not be called statically

Do this instead

$fb = new foobar;
echo $fb->foobarfunc();

On a sidenote, I suggest not to use global inside your classes. If you need something from outside inside your class, pass it through the constructor. This is called Dependency Injection and it will make your code much more maintainable and less dependant on outside things.

Gordon
+2  A: 

When you call the function in a static context, $this simply doesn't exist.

You would have to use this::xyz() instead.

To find out what context you're in when a function can be called both statically and in an object instance, a good approach is outlined in this question: How to tell whether I’m static or an object?

Pekka
+3  A: 

You are calling a non-static method :

public function foobarfunc() {
    return $this->foo();
}

Using a static-call :

foobar::foobarfunc();

When using a static-call, the function will be called (even if not declared as static), but, as there is no instance of an object, there is no $this.

So :

  • You should not use static calls for non-static methods
  • Your static methods (or statically-called methods) can't use $this, which normally points to the current instance of the class, as there is no class instance when you're using static-calls.


Here, the methods of your class are using the current instance of the class, as they need to access the $foo property of the class.

This means your methods need an instance of the class -- which means they cannot be static.

This means you shouldn't use static calls : you should instanciate the class, and use the object to call the methods, like you did in your last portion of code :

$foobar = new foobar();
$foobar->foobarfunc();


For more informations, don't hesitate to read, in the PHP manual :


Also note that you probably don't need this line in your __construct method :

global $foo;

Using the global keyword will make the $foo variable, declared outside of all functions and classes, visibile from inside that method... And you probably don't have such a $foo variable.

To access the $foo class-property, you only need to use $this->foo, like you did.

Pascal MARTIN
A: 

$foobar = new foobar; put the class foobar in $foobar, not the object. To get the object, you need to add parenthesis: $foobar = new foobar();

Your error is simply that you call a method on a class, so there is no $this since $this only exists in objects.

e-satis