views:

639

answers:

5

I have this code

public static Boolean freq[] = new Boolean[Global.iParameter[2]];
freq[Global.iParameter[2]] = false;

could someone tell me what exactly i'm doing wrong here and how would i correct it? I just need to initialize all the array elements to Boolean false. thank you

+3  A: 

The array will be initialized to false when you allocate it.

All arrays in Java are initialized to the default value for the type. This means that arrays of ints are initialised to 0, arrays of booleans are initialised to false and arrays of reference types are initialised to null.

You can find more details here.

Jørgen Fogh
He's using `Boolean`, not `boolean`, so it will default to `null`.
BalusC
Correct. I did not see that. Arrays.fill should do the trick.
Jørgen Fogh
+2  A: 

public static Boolean freq[] = new Boolean[Global.iParameter[2]];

Global.iParameter[2]:

It should be const value

oneat
this is not true. could be variables as well. the problem is that you are using Global.iParameter[2] to access the array. but the indices are going from 0 until only Global.iParameter[2]-1 !!
Karussell
+2  A: 

They will be initialized to false by default. In Java arrays are created on heap and every element of the array is given a default value depending on its type. For boolean data type the default value is false.

codaddict
He's using `Boolean`, not `boolean`, so it will default to `null`.
BalusC
oops..didnt see that. Thanks BalusC :)
codaddict
i meant to use boolean, my bad...sorry for the mislead
rookie
+6  A: 

I just need to initialize all the array elements to Boolean false.

Either use boolean[] instead so that all values defaults to false:

boolean[] array = new boolean[size];

Or use Arrays#fill() to fill the entire array with Boolean.FALSE:

Boolean[] array = new Boolean[size];
Arrays.fill(array, Boolean.FALSE);

Also note that the array index is zero based. To learn more about arrays in Java, consult this Sun basic tutorial.

BalusC
thk u very much
rookie
+5  A: 

Arrays in Java start indexing at 0. So in your example you are referring to an element that is outside the array by one.

It should probably be something like freq[Global.iParameter[2]-1]=false;

You would need to loop through the array to initialize all of it, this line only initializes the last element.

Actually, I'm pretty sure that false is default for booleans in Java, so you might not need to initialize at all.

Best Regards

Big Endian
He's using `Boolean`, not `boolean`, so it will default to `null`.
BalusC