views:

763

answers:

3

I have a PHP class that creates a PNG image on the fly and sends it to browser. PHP manual says that I need to make sure that imagedestroy function is called at end to release the memory. Now, if I weren't using a class, I would have some code like this:

function shutdown_func() 
{
    global $img;
    if ($img)
        imagedestroy($img);
}
register_shutdown_function("shutdown_func");

However, I believe that appropriate place for my class would be to place a call to imagedestroy in class' destructor.

I failed to find out if destructors get called the same way shutdown functions does? For example, if execution stops when user presses the STOP button in browser.

Note: whatever you write in your answer, please point to some article or manual page (URL) that supports it.

A: 

I think one big thing that you have missed is that all the memory PHP has allocated during script execution is freed once the script terminates. Even if the user presses the stop-button, PHP processes the script until it is finished, gives it back to the HTTP daemon to be served to the visitor (or not, depending on how clever the daemon is).

So, explicitly freeing up memory at the end of script execution is a bit redundant. Some might argue that it would be a good thing to do, but it's still redundant.

But, on the topic of class destructors, they are called whenever the object is destroyed, either explicitly by unset() or at script completion/termination.

The recommendation of the developer explicitly freeing up the memory used in image manipulation is sure just to make absolutely sure not to have a memory leak, as bitmaps can be straining on the memory side of things (height * width * bit depth * 3 (+ 1 if you have an alpha channel))

To satisfy your Wikipedian needs:

Henrik Paul
AFAIU, memory is not allocated by PHP because it invokes GD to create images and GD does not have garbage collection.
Milan Babuškov
I already read PHP manual, but it does not explicitly say whether destructor is called if script is terminated by web server.
Milan Babuškov
also AFAIK, GD is just a library that is dynamically linked with PHP. This would imply that while GD knows how to do all the stuff, it's still PHP's memory and thus PHP's garbage collection.
Henrik Paul
@wolfie: no. I just tested and it leaks memory. Since PHP is Apache module, it gets returned to OS when Apache is restarted, which I don't do that often (any hosting company tries not to restart web server at all)
Milan Babuškov
+3  A: 

I just tested with Apache, PHP being used as Apache module. I created an endless loop like this:

<?php
class X
{
    function __destruct()
    {
        $fp = fopen("/var/www/htdocs/dtor.txt", "w+");
        fputs($fp, "Destroyed\n");
        fclose($fp);
    }
};

$obj = new X();
while (true) {
    // do nothing
}
?>

Here's what I found out:

  • pressing STOP button in Firefox does not stop this script
  • If I shut down Apache, destructor does not get called
  • It stops when it reaches PHP max_execution_time and destuctor does not get called

However, doing this:

<?php
function shutdown_func() {
    $fp = fopen("/var/www/htdocs/dtor.txt", "w+");
    fputs($fp, "Destroyed2\n");
    fclose($fp);
}
register_shutdown_function("shutdown_func");

while (true) {
    // do nothing
}
?>

shutdown_func gets called. So this means that class destuctor is not that good as shutdown functions.

Milan Babuškov
Can you add a link to anything in the php manual or otherwise that supports your test? That would be of great benefit to us all.
Noah Goodrich
If you have a working setup, just copy/paste this examples I gave and try yourself. It it was explained in PHP manual or otherwise I wouldn't ask here at SO.
Milan Babuškov
This behavior is not "by design" so it may change in future versions. If no output is send to the browser the stop button has no effect. "echo" is a function that can cause a fatal error (broken pipe). Thanks for your research but in the GD img case everybody should use the destructor method.
Bob Fanger
+1  A: 

Based on the principle that you should finish what you start, I'd say the destructor is the correct place for the free call.

The destructor will be called when the object is disposed of, whereas a shutdown function will not be called until script execution finishes. As noted by Wolfie, these won't necessarily happen if you forcibly halt the server or the script, but at that time, the memory allocated by PHP will be freed anyway.

Also noted by Wolfie, PHP will free up script resources when the script closes, so if you're only instantiating one of these objects, then you probably wouldn't notice a massive difference. However, if you later do end up instantiating these things, or do so in a loop, then you probably don't want to have to worry about a sudden spike in memory usage, so for the sake of future sanity, I return to my original recommendation; put it in the destructor.

Rob