views:

1082

answers:

5

Hey,

I am trying to access an instance variable which is set in the controller in the model. The controller is the products controller and the model is the products model. The instance variable is a instance of another model called account.

The instance variable is @current_account

When I run the code nothing happens, I do not get an error. Does anyone know where I can find something read about access instance variables set in the controller from the model?

Thanks

Eef

A: 

I'm not sure if I understand the question exactly, but I'll take a stab.

I think if you need to access a controller instance variable from the model then you either need to make it an attribute in the model, or move your logic to the other class controller, not model.

ghoppe
+6  A: 

You shouldn't generally try to access the controller from the model for high-minded issues I won't go into.

I solved a similar problem like so:

class Account < ActiveRecord::Base
  cattr_accessor :current
end

class ApplicationController < ActionController::Base
  before_filter :set_current_account
  def set_current_account
    #  set @current_account from session data here
    Account.current = @current_account
  end
end

Then just access the current account with Account.current

jeem
+1 for being more specific than me :)
ghoppe
Aren't class variables shared across all requests?!
vise
I don't understand how to get the variable value from the :current symbol in the model? I tried Account.current and current.
bandhunt
What's the difference between `cattr_accessor` and `attr_accessor`?
cattr_accessor is attached to the class, like `self.value`, rather than a method `value`.
Garrett
+2  A: 

If you need to access a controller variable from a model it generally means your design is wrong because a controller serves as bridge between view and model (at least in Rails), controller gets info from models, models shouldn't know anything about controllers, but if you want to do it anyway you can do it just as jeem said, but I'd rather do:

 class << self

    attr_accessor :current

 end

instead of

cattr_accessor :current

you can see why here => cattr_accessor doesn't work as it should

raf
A: 

I can't comment directly so I'll post here: the accepted answer does not seem to be right. As @vise notes, class variables are shared across requests. So unless there's just one current account for the entire app, this won't behave as expected.

For more, see the accepted answer by @molf here: http://stackoverflow.com/questions/1025432/is-rails-shared-nothing-or-can-separate-requests-access-the-same-runtime-variable

Jacob
A: 

use self keyword.. like if there is a field in your form with name than access it using self.name