Javascript Browser Issue

Question

I'm new to javascript, my script is designed to display either one image or the other image with a 50/50 chance. It worked in safari but not in firefox, this cuts out too many customers for the website I'm designing for.
Any help would be appreciated, especially if anyone could say how to make sure it would work across all browsers. Otherwise I can figure out how to make it ignore it in firefox or some other such combination.

var randomnumber=Math.floor(Math.random()*2)

if (randomnumber > 0)
{
    document.write("<img src="Easter.jpg">");
}
else
{
    document.write("<img src="StPatrick.jpg">");
}

Oh and the actual code has & q u o t ; instead of " where it needs to be in case you were wondering if that was making it not work. It does work in safari - just not in firefox or camino.

Answer 1

You need to escape the inner quotes:

if (randomnumber > 0)
{
document.write("<img src=\"Easter.jpg\">");
}
else
{ 
document.write("<img src=\"StPatrick.jpg\">");
}

Inside a string which is terminated by ", when you want to insert a double-quote, you need to "escape" it by putting a \ before it

EDIT: I just saw your edit where you said the actual code has " in it. If you code is:

document.write("<img src=&quot;Easter.jpg&quot;>");

That won't work. it will literally write:

<img src=&quot;Easter.jpg&quot;>

Change the " to \"

Answer 2

Try

var randomnumber=Math.floor(Math.random()*2)

if (randomnumber > 0) {
  document.write("<img src='Easter.jpg' />");
}
else {
  document.write("<img src='StPatrick.jpg' />");
}

You might want to consider a different tactic to using document.write() though, perhaps creating the element using new Image() and appending it to the DOM.

Answer 3

Your quotes need fixing. You need nested quotes in your document.wrote statements, but you're using the same quotation marks for both the outer and inner quotes.

When the browser sees the second double-quote, it closes the string it's building, so you get a string containing <img src=

HTML supports both single and doube quotes so you can alternate them to avoid this problem. Or, you an escape the inner quotes, but that's harder to read; alternating single- and double-quotes is usually all you need.

Change

document.write("<img src="Easter.jpg">")

to

document.write("<img src='Easter.jpg'>")