ansaurus

Question

PHP, javascript, single quote problems with IE when passing variable from ajax post to javascript function

Answer 1

+1 A:

what about backslash escaping it?:

$city = str_replace("'","\'",$row['City']);

easement 2010-03-12 16:42:56

Tried it, don't think it worked, but I have flipped around with different settings so much I couldn't be sure :) Gumbos solution up there were nice though.

Mattis 2010-03-12 20:10:04

Answer 2

+2 A:

You need two encodings: One for the JavaScript context and one for the HTML context:

json_encode is for encoding the data for JavaScript and
htmlspecialchars for the HTML part.

So try this:

echo '<li onclick="script(' . htmlspecialchars(json_encode($row['City'])) . ')">' . htmlspecialchars($row['City']) . '</li>';

Gumbo 2010-03-12 16:45:48

You are a god given man to the lesser gifted :) Works perfectly, nice solution.

Mattis 2010-03-12 20:08:27

Answer 3

+2 A:

You could call script() and then reference this.innerhtml.

<li onclick="script();">$data</li>

And then in your javascript:

function script() {
    data = this.innerHTML;
    // do stuff
}

thetaiko 2010-03-12 16:49:05

It’s `innerHTML` and not `innerhtml`.

Gumbo 2010-03-12 16:49:38

Answer 4

+1 A:

To make your life easier, I would dispense with using onclick if you can and include scripts in the <head> of the page and register click handlers based on id/class. And even better, use jQuery to do that, but you're probably aware of jQuery already if you've been around S.O. enough.

Single/Double/Triple escaping all the time just isn't worth it.

Tchalvak 2010-03-12 16:53:05

You are probably right about that, I am evolving the example I found. Will probably make it more intuitive in further developments.

Mattis 2010-03-12 20:09:18

Answer 5

+1 A:

My contribution to proceedings, uses your existing function with minimal change.

<li onclick="script(this.innerHTML);">$data</li>

Sohnee 2010-03-12 17:01:41

ansaurus

tags:

views:

answers:

PHP, javascript, single quote problems with IE when passing variable from ajax post to javascript function

related questions