views:

1863

answers:

6

One of our customers wants to be able to enter a date with only 2 digits for the year component. The date will be in the past, so we want it to work for the previous century if the 2 digit year is after the current year, but work for the current century if the 2 digit year is equal to or less than the current year.

as of today 10/30/2008

01/01/01 = 01/01/2001

01/01/09 = 01/01/1909

This is a strange requirement, and I solved the problem, I just don't like my solution. It feels like there is a better way to do this.

Thanks for the help.

public static String stupidDate(String dateString)
{
 String twoDigitYear = StringUtils.right(dateString, 2);
 String newDate = StringUtils.left(dateString, dateString.length() - 2);
 int year = NumberUtils.toInt(twoDigitYear);
 Calendar c = GregorianCalendar.getInstance();
 int centuryInt = c.get(Calendar.YEAR) - year;
 newDate = newDate + StringUtils.left(Integer.toString(centuryInt), 2) + twoDigitYear;
 return newDate;
}
A: 

It's been a while since I've used java, so I'm going to use pseudo code.

If I understand what you're trying to get at, the easiest solution is something like this:

myDate = ParseDate(thatString);
if (myDate > Now)
    myDate = myDate.AddYears(-100)
John
+4  A: 

How about this:

public static String anEasierStupidDateWithNoStringParsing(String dateString) {
    DateFormat df = new SimpleDateFormat("MM/dd/yyyy");

    //handling ParseExceptions is an exercise left to the reader!
    Date date = df.parse(dateString);
    Calendar cal = Calendar.getInstance();
    cal.setTime(date);

    Calendar now = Calendar.getInstance();
    if (cal.after(now)) {
        cal.add(Calendar.YEAR, -100);
    }

    return cal;
}

In other words, let SimpleDateFormat parse the String and just adjust the year to be the previous century if SimpleDateFormat (which has it's own rules for interpreting year strings) returns a date that is after the current date.

This would guarantee that all dates returned are in the past. However, it doesn't account for any dates that might be parsed as before this past century - for example, with the format MM/dd/yyyy, a date string like "01/11/12" parses to Jan 11, 12 A.D.

matt b
+2  A: 

If Joda Time is an option:

String inputDate = "01/01/08";
// assuming U.S. style date, since it's not clear from your original question
DateTimeFormatter parser = DateTimeFormat.forPattern("MM/dd/yy");
DateTime dateTime = parser.parseDateTime(inputDate);
// if after current time
if (dateTime.isAfter(new DateTime())) {
    dateTime = dateTime.minus(Years.ONE);
}

return dateTime.toString("MM/dd/yyyy");

I know Joda Time isn't part of Java SE, and as I've said in another thread, I usually do not condone using a third-party library when there's a Java library that does the same thing. However, the person who is developing Joda Time is also leading JSR310 - the Date and Time API that'll make it into Java 7. So I Joda Time is basically going to be in future Java releases.

Jack Leow
You should use joda time Freaky Formatters to append2digitYear http://joda-time.sourceforge.net/userguide.html#Freaky_Formatters
Alex B
I thought about doing something like that, but that would mean that the current year will always be treated as the current year, even if it's some time in the future (i.e., 12/31/08 would be 12/31/2008 instead of 12/31/1908).I guess the correct solution would depend on the client's requirements.
Jack Leow
+1  A: 

SimpleDateFormat already does two-digit year parsing for you, using the two-letter ‘yy’ format. (It'll still allow four digits, obviously.)

By default it uses now-80→now+20, so it's not exactly the same rule you propose, but it's reasonable and standardised (in the Java world at least), and can be overridden using set2DigitYearStart() if you want.

DateFormat informat= new SimpleDateFormat("MM/dd/yy");
DateFormat outformat= new SimpleDateFormat("MM/dd/yyyy");
return outformat.format(informat.parse(dateString));

In the longer term, try to migrate to ISO8601 date formatting (yyyy-MM-dd), because MM/dd/yy is approximately the worst possible date format and is bound to cause problems eventually.

bobince
He said his client explicitly asked for that particular 2 digit year rule. :)
Jack Leow
Yeah if it were up to me I'd say we require a four digit year. Problem solved.
ScArcher2
Indeed - clients are fools! :-) Which is why it needs to be approached sneakily!
bobince
+1  A: 

Groovy script (easy enough to throw into java) demonstrating the point @bobince made about SimpleDateFormat.

java.text.SimpleDateFormat sdf = new java.text.SimpleDateFormat('MM/dd/yy')
java.text.SimpleDateFormat fmt = new java.text.SimpleDateFormat('yyyy-MM-dd')
Calendar cal = Calendar.getInstance()
cal.add(Calendar.YEAR, -100)
sdf.set2DigitYearStart(cal.getTime())
dates = ['01/01/01', '10/30/08','01/01/09']
dates.each {String d ->
  println fmt.format(sdf.parse(d))
}

Yeilds

2001-01-01
2008-10-30
1909-01-01
Ken Gentle
This is almost exactly what I ended up doing! It does easily translate to java. Thanks!
ScArcher2
A: 

The best way is to use the Joda Time API for dates and times in Java.

Steve McLeod