views:

247

answers:

3

In using a function, I wish to ensure that the type of the variables are as expected. How to do it right?

Here is an example fake function trying to do just this before going on with its role:

def my_print(begin, text, end):
    """Print 'text' in UPPER between 'begin' and 'end' in lower

    """
    for i in (begin, text, end):
        assert isinstance(i, str), "Input variables should be strings"
    out = begin.lower() + text.upper() + end.lower()
    print out

def test():
    """Put your test cases here!

    """
    assert my_print("asdf", "fssfpoie", "fsodf")
    assert not my_print("fasdf", 33, "adfas")
    print "All tests passed"

test()

Is assert the right approach? Should I use try/except instead?

Also, my assert set of tests does not seem to work properly :S

Thanks pythoneers

+1  A: 

You might want to try this example for version 2.6 of Python.

def my_print(text, begin, end):
    "Print text in UPPER between 'begin' and 'end' in lower."
    for obj in (text, begin, end):
        assert isinstance(obj, str), 'Argument of wrong type!'
    print begin.lower() + begin.upper() + end.lower()

However, have you considered letting the function fail naturally instead?

Noctis Skytower
I'm a bit retrograde and am still using 2.6 :P Thanks for the 'isinstance()' function.
Morlock
The new version should work with version 2.6 now.
Noctis Skytower
+7  A: 

The isinstance built-in is the preferred way if you really must, but even better is to remember Python's motto: "it's easier to ask forgiveness than permission"!-) (It was actually Grace Murray Hopper's favorite motto;-). I.e.:

def my_print(text, begin, end):
    "Print 'text' in UPPER between 'begin' and 'end' in lower"
    try:
      print begin.lower() + text.upper() + end.lower()
    except (AttributeError, TypeError):
      raise AssertionError('Input variables should be strings')

This, BTW, lets the function work just fine on Unicode strings -- without any extra effort!-)

Alex Martelli
Is there any use for 'assert' then? In testing?
Morlock
Alex Martelli
Thank you for the clarification.
Morlock
The my_print function shouldn't really care if the arguments are of type str, or unicode; it just cares that the arguments have `lower()`, `upper()`, and `__add__()` methods. This is called duck typing (it looks like a duck and talks like a duck (i.e.has the same methods), even if it really isn't a duck at all), and it is the preferred method for python.If you are going to raise an Exception because the arguments passed in were of the wrong type, you should raise a `TypeError`.
Brendan Abel
@007brendan, http://en.wikipedia.org/wiki/Duck_typing under History credits me with the earliest traceable use of the term "duck typing" (10 years ago, back when I was a raw beginner in Python) though if you read my post they point to, I don't actually _use_ the phrase in that post (I make up lots of duck-analogies, but mostly use more traditional terms such as "typeswitching") -- anyway, I think that makes me reasonably conversant with the concept;-). I agree a type error is a good match (the try/except can turn attribute errors, always a hybrid thingy, into type errors).
Alex Martelli
@Alex, I use your advice and solutions in a lot of my own programming, so I realize you have an incredible wealth of knowledge and experience in all these areas (I'm even using your own analogies!). My post was intended more for the OP to provide some context as to why your solution is the canonical one.
Brendan Abel
A: 

Doing type('') is effectively equivalent to str and types.StringType

so type('') == str == types.StringType will evaluate to "True"

Note that Unicode strings which only contain ASCII will fail if checking types in this way, so you may want to do something like assert type(s) in (str, unicode) or assert isinstance(obj, basestring), the latter of which was suggested in the comments by 007Brendan and is probably preferred.

isinstance() is useful if you want to ask whether an object is an instance of a class, e.g:

class MyClass: pass

print isinstance(MyClass(), MyClass) # -> True
print isinstance(MyClass, MyClass()) # -> TypeError exception

But for basic types, e.g. str, unicode, int, float, long etc asking type(var) == TYPE will work OK.

David Morrissey
You can do -- assert isinstance(obj, basestring) -- str and unicode both inherit from basestring, so this will work for both.
Brendan Abel
Thanks for that suggestion - I've added it to the answer.
David Morrissey