ansaurus

Question

Java: Interface for this code

Answer 1

+2 A:

How can you make interface for this if all the methods are private?

jpartogi 2010-04-11 08:20:51

Answer 2

+1 A:

Determine which methods need to exposed to the world and then make an interface out of it.

fastcodejava 2010-04-11 08:30:14

Answer 3

A:

I have the need to post internal codes entirely unedited to Stackoverflow, too.

Besides the code snips and looks plain terrible, just adding an interface isn't going to make it any better. static fields shared among instances are always a horror...gah, it's Sunday, I'm not going to start a code review for your send-teh-codez.

Esko 2010-04-11 08:37:54

Not had your coffee yet?

John 2010-08-04 17:58:09

@John: Can't remember, that was four months ago. You're a bit late here?

Esko 2010-08-04 19:34:03

You're right, I didn't check the date. The question was on the front page an hour ago. I guess It's I who should go get a cup of coffee.

John 2010-08-04 19:43:52

@John: I do take your remark (to my remark) as valid feedback though. I can imagine I was annoyed because of something when I read this so the downvote is deserved.

Esko 2010-08-05 07:28:47

I am not the one who downvoted however!

John 2010-08-05 12:48:06

Answer 4

+1 A:

I'll bite:

import org.w3c.dom.Document;

public interface Transformer {

    /**
     * initialize the <code>DocumentBuilder</code> and read the XSD file
     * 
     * @param docPath
     * @return the <code>Document</code> object representing the read XSD file
     */
    Document retrieveDoc(String docPath);

    /**
     * perform the iteration/modification on the document iterate to the level
     * which contains all the elements (Single-Value, and Groups) and start
     * processing each
     * 
     * @param xsdDoc
     * @return
     */
    Document transformDoc(Document xsdDoc);

}

Make retrieveDoc and transformDoc public in your XSDTransformer class

public interface XSDTransformerConstants {

    /**
     * constants representing the XSD tags and attributes' names used in the
     * parse process
     */
    String TAG_SCHEMA = "xsd:schema";
    String TAG_TEXT = "#text";
    String TAG_COMPLEX_TYPE = "xsd:complexType";
    String TAG_SIMPLE_TYPE = "xsd:simpleType";
    String TAG_SEQUENCE = "xsd:sequence";
    String TAG_ATTRIBUTE = "xsd:attribute";
    String TAG_ELEMENT = "xsd:element";
    String TAG_ANNOTATION = "xsd:annotation";
    String TAG_APP_INFO = "xsd:appinfo";
    String TAG_HAS_PROPERTY = "xsd:hasProperty";
    String TAG_RESTRICTION = "xsd:restriction";
    String TAG_MAX_LENGTH = "xsd:maxLength";
    String ATTR_NAME = "name";
    String ATTR_VALUE = "value";
    String ATTR_TYPE = "type";
    String ATTR_MIXED = "mixed";
    String ATTR_USE = "use";
    String ATTR_REF = "ref";
    String ATTR_MAX_OCCURS = "maxOccurs";
    /**
     * constants representing specific XSD attributes' values used in the parse
     * process
     */
    String FIELD_TAG = "fieldtag";
    String FIELD_NUMBER = "fieldnumber";
    String FIELD_DATA_TYPE = "fielddatatype";
    String FIELD_FMT = "fieldfmt";
    String FIELD_LEN = "fieldlen";
    String FIELD_INPUT_LEN = "fieldinputlen";
    String FIELD_GROUP_NUMBER = "fieldgroupnumber";
    String FIELD_MV_GROUP_NUMBER = "fieldmvgroupnumber";
    String FIELD_SHORT_NAME = "fieldshortname";
    String FIELD_NAME = "fieldname";
    String FIELD_COLUMN_NAME = "fieldcolumnname";
    String FIELD_GROUP_NAME = "fieldgroupname";
    String FIELD_MV_GROUP_NAME = "fieldmvgroupname";
    String FIELD_JUSTIFICATION = "fieldjustification";
    String FIELD_TYPE = "fieldtype";
    String FIELD_SINGLE_OR_MULTI = "singleormulti";
    String DELIMITER_COLUMN_TYPE = "#";
    String COLUMN_FK_ROW = "FK_ROW";
    String COLUMN_XPK_ROW = "XPK_ROW";
    int SQL_VIEW_MULTI = 1;
    int SQL_VIEW_SINGLE = 2;
    String DATA_TYPE_XSD_NUMERIC = "numeric";
    String DATA_TYPE_XSD_DECIMAL = "decimal";
    String DATA_TYPE_XSD_STRING = "string";
    String DATA_TYPE_XSD_DATE = "date";
    /**
     * application configuration properties
     */
    String PROP_LOG4J_CONFIG_FILE = "log4j_config";
    String PROP_MAIN_VIEW_NAME_SINGLE = "view_name_single";
    String PROP_MAIN_VIEW_NAME_MULTI = "view_name_multi";
    String PROP_MAIN_TABLE_NAME = "main_edh_table_name";
    String PROP_SUB_TABLE_PREFIX = "sub_table_prefix";
    String PROP_SOURCE_XSD_FULLNAME = "source_xsd_fullname";
    String PROP_RESULTS_PATH = "results_path";
    String PROP_NEW_XSD_FILENAME = "new_xsd_filename";
    String PROP_CSV_FILENAME = "csv_filename";
}

Classes referring to these constants should now do so via a static reference to XSDTransformerConstants.

Adriaan Koster 2010-04-11 17:36:17

ansaurus

tags:

views:

answers:

Java: Interface for this code

related questions