views:

214

answers:

2

I have some code that is using reflection to pull property values from an object. In some cases the properties may throw exceptions, because they have null references etc.

                    object result;
                    try
                    {
                        result = propertyInfo.GetValue(target, null);

                    }
                    catch (TargetInvocationException ex)
                    {
                        result = ex.InnerException.Message;
                    }
                    catch (Exception ex)
                    {
                        result = ex.Message;
                    }

Ultimately the code works correctly, however when I am running under the debugger : When the property throws an exception, the IDE drops into the debugger as if the exception was uncaught. If I just hit run, the program flows through and the exception comes out as a TargetInvocationException with the real exception in the InnerException property.

How can I stop this from happening?

+1  A: 

EDIT: I've just tried this myself, and it looks like reflection is treated slightly differently. You might want to think of a reflection call as starting a new level of "handled" as far as the debugger is concerned: nothing is catching that exception before it gets translated and rethrown as a TargetInvocationException, so it breaks in. I don't know if there's any way of inhibiting that - but does it happen very often? If you're regularly performing lots of operations which result in exceptions, you might want to reconsider your design.


Original answer

Go to Debug / Exceptions... and see what the settings are. You'll see this behaviour if TargetInvocationException (or anything higher in the hierarchy) has the "Thrown" tickbox checked.

Jon Skeet
The use case is a "watch window" for variables that my app is using. To be able to show the user the state of what is going on in the application. So it only happens when the user is requesting the watch window to be updated. At runtime its not really a problem as the exception is ultimately caught, but during development its a huge pain because it keeps breaking me out of running!
Jason Coyne
My first Jon Skeet response!
Jason Coyne
@Jason: Yes, I can see that being a pain. I don't know of a way round it I'm afraid. For most situations it's probably the right behaviour.
Jon Skeet
Why would this be the right behavior? If I said to catch it, isn't it caught?
Jason Coyne
@Jason: The problem is that you're not really specifying what kind of exception you want caught in the way that you normally would. The translation layer is effectively hidden from you by the fact that you're using reflection. You can't explicitly target one kind of exception being thrown by the caller.
Jon Skeet
How is catch(Exception) not catching everything?
Jason Coyne
@Jason: You've missed my point: that `catch(Exception)` isn't saying "I want to catch any exception thrown by reflection" - the `TargetInvocationException` is already doing that. The point is that you don't get to say, "I want to catch IOException" when you use reflection; you just have to catch everything by using `TargetInvocationException`.
Jon Skeet
+1  A: 

Hm, it appears to be a bug in Visual Studio. Thanks for letting us know, we're looking at it.

EDIT: I've followed up and this seems to be "by design". What happens is that you likely have Tools -> Options -> Debugging -> General -> Enable Just My Code.

As the help file here states: http://msdn.microsoft.com/en-us/library/038tzxdw.aspx The Debug -> Exceptions dialog shows an additional column (Break when an exception is User-unhandled) when "Enable Just My Code" is on. Essentially this means that whenever the exception is leaving the boundary of your code (and in this case, it falls through down to the .NET framework reflection code), VS breaks because it thinks that the exception has left the user code. It doesn't know that it will return into the user code later in the stack.

So there are two workarounds: Disable Just My Code in Tools -> Options -> Debugging -> General or Remove the check box from the User-unhandled .NET Framework exceptions in the Debug -> Exceptions dialog.

Hope this helps!

Kirill Osenkov