Is there any significant benefit to reading string directly from control instead of moving it into a variable?

Question

sqlInsertFrame.Parameters.AddWithValue("@UserName", txtUserName.txt);

Given the code above...if I don't have any need to move the textbox data into a string variable, is it best to read the data directly from the control?

In terms of performance, it would seem smartest to not create any unnecessary variables which use up memory if its not needed. Or is this a situation where its technically true but doesn't yield any real world results due to the size of the data in question.

Forgive me, I know this is a very basic question.

Answer 1

Never cache what you can compute. Your reasoning is sound.

Answer 2

Actually it's not a very basic question at all. As far as performance goes it's hard to say without measuring. In this case, a local variable in an inner scope may well get optimized completely out of the picture by a smart compiler. It may exist only in the CPU registers.

Introducing a local variable can make your code much more readable, if it does, do it!

See also ... http://stackoverflow.com/questions/1438158/local-variable-assignment-to-avoid-multiple-casts and, in particular, the accepted answer.

Answer 3

No validation? Usually I cache the string and pass it to the business layer for validation, if the validation succeeds, then I save the cached string to the database. It is slower to get the string again from the Window than read the value off my cache.

Answer 4

Also if you do this from a thread you're likely to get a cross thread operation exception.