jQuery broken function after added new function

Question

What's wrong here? The alert function was working until I added this new function to it.

Is there anything I am doing wrong? It just simply doesn't fire the alert anymore.

<input value="1"  type="checkbox" name="salgsvilkar" id="checkbox2"  style="float:left;"
        />

    {literal}
             <script src="http://code.jquery.com/jquery-latest.js"&gt;&lt;/script&gt;
                <script type="text/javascript">
    $(function() {
       //checkbox
       $("#scrollwrap").click(function(){
        $("#scrollwrap").toggleClass('highlight');
        });​
    });

    $(function(){
       //button
       $("#fullfor_btn").click(function(e){
           if(!$("#checkbox2").is(':checked') == false)
           {
               alert("Please accept the terms of sale."); 
               e.preventDefault();
           }
       });
     });
    </script>
      {/literal}


<button type="submit" class="submit" name="{$method}" id="fullfor_btn" title="Fullfør bestillingen nå" value="">&nbsp;</button>

Answer 1

you can put all your code in the same $(function(){ code }) in your example, you are setting the document ready twice

 $(function() {
   //checkbox
   $("#scrollwrap").click(function(){
    $("#scrollwrap").toggleClass('highlight');
   });​

   //button
   $("#fullfor_btn").click(function(e){
       if($("#checkbox2").is(':checked'))
       {
           alert("Please accept the terms of sale."); 
           e.preventDefault();
       }
   });
 });

Answer 2

Instead of:

if(!$("#checkbox2").is(':checked') == false) {

why not just use the much more readable:

if($("#checkbox2").is(':checked')) {

EDIT: If your intention is for the alert to fire when the checkbox is not checked:

if(!$("#checkbox2").is(':checked')) {

Answer 3

Your logic is probably not what you intended, as karim79 said.

if(!$("#checkbox2").is(':checked') == false)

is identical in function to

if($("#checkbox2").is(':checked') == true)

so your alert will only trigger when the checkbox is checked.

Answer 4

Works for me.

Though it seems a little odd that you'd trigger the alert when the checkbox is checked, instead of when it is not.