What's wrong with my logic (Java syntax)

Question

I'm trying to make a simple program that picks a random number and takes input from the user. The program should tell the user if the guess was hot (-/+ 5 units) or cold, but I never reach the else condition.

Here's the section of code:

    public static void giveHint (int guess) {
    int min = guess - 5;
    int max = guess + 5;
    if ((guess > min) && (guess < max)) {
        System.out.println("Hot..");
    } else {
        System.out.println("Cold..");
    }
}

Answer 1

Here is your problem:

int min = guess - 5;
int max = guess + 5;

min is ALWAYS lesser than guess and max is ALWAYS greater than guess.

Answer 2

int min = guess - 5;
int max = guess + 5;

Should be:

int min = actualAnswer - 5;
int max = actualAnswer + 5;

Answer 3

You're calculating min and max based on guess, so guess is always between min and max so (guess > min) && (guess < max) is always true.

Answer 4

You need to pass in the actual answer, not just the guess, since the logic can't tell what the appropriate mix/max should be otherwise:

public static void giveHint (int guess, int actual) {
    int min = actual - 5;
    int max = actual + 5;
    if ((guess > min) && (guess < max)) {
        System.out.println("Hot..");
    } else {
        System.out.println("Cold..");
    }
}

Answer 5

Lets use an example:

int guess = 20;
int min = guess - 5 = 15;
int max = guess + 5 = 25;

therefore

min < guess < max

Why?

Because you're comparing guess to its self! I think you need to have the actual answer, not the guess

Answer 6

You are defining guess as being > min (because min = guess - 1) and as being < max (because max = guess + 5).

Answer 7

I can't put the full thing in a comment, so here's what your code should be:

    public static void giveHint (int guess, int actual) {
    int min = actual - 5;
    int max = actual + 5;
    if ((guess > min) && (guess < max)) {
        System.out.println("Hot..");
    } else {
        System.out.println("Cold..");
    }