Code formatting for initializing lists

Question

I've just found in my java project this code snippet:

List<IssueType> selectedIssueTypes = new ArrayList<IssueType>();  
    for (Object item : selectedItems) 
        selectedIssueTypes.add((IssueType) item);

How do you think, can this style be used?

Answer 1

Imho, this style seems to show a hierarchy that isn't there. Also I would advocate to always use braces and I like to separate declarations and code with an empty line, so I would use:

List<IssueType> selectedIssueTypes = new ArrayList<IssueType>();  

for (Object item : selectedItems) {
    selectedIssueTypes.add((IssueType) item);
}

Answer 2

I think this would be much clearer and less prone to problems when another developer looks at it.

List<IssueType> selectedIssueTypes = new ArrayList<IssueType>();  
for (Object item : selectedItems) {
    selectedIssueTypes.add((IssueType) item);
}

Always use brackets to clarify loops. Do not indent the for statement, as it's against standard practice.

Answer 3

Why not simply:

List<IssueType> selectedIssueType = Arrays.asList(selectedItems);