ansaurus

Question

Why is my model firing the validation at the wrong time?

Answer 1

+1 A:

This is happening because whenever you add an AR object to an association array it will save the object and try and add its id to the association table (if it is many_to_many)

You may try the following

#Employee#edit
69: if @employee.user.person.addresses.length == 0
70:   @employee.user.person.addresses = [Address.new]
71: end

Also if you are doing this with accepts_nested_attributes_for the convention is to use the build method

#Employee#edit
69: if @employee.user.person.addresses.length == 0
70:   @employee.user.person.addresses.build
71: end

See http://ryandaigle.com/articles/2009/2/1/what-s-new-in-edge-rails-nested-attributes for more information

Will 2010-05-09 05:12:45

Answer 2

+1 A:

First, may I suggest you check as follows, for semantic clarity:

if @employee.user.person.addresses.empty?

Next, if you check your logs you will see that addresses (and the corresponding address_person_link) are added to the database by the "<<" method, this in turn calls the validation and this is why your save fails (as a newly created address doesn't validate).

You could modify your address validations to avoid running them if it's a newly created record (such as when you just added it to a person using "<<". Like this:

validates_presence_of :name, :unless => Proc.new{|a|a.new_record?}

You'd have to add the :unless block to every one on your validations on Address.

Roadmaster 2010-05-09 05:18:47

ansaurus

tags:

views:

answers:

Why is my model firing the validation at the wrong time?

related questions