views:

239

answers:

2

Note: This is an assignment.

Hi,

Continuing with my Set implementation using Java basic array, I'm now struggling with the 3 to last function namely the union.

import java.io.*;

class Set {

       private int numberOfElements = 0;
       private String[] setElements = new String[5]; 
       private int maxNumberOfElements = 5;

       // constructor for our Set class   

       public Set(int numberOfE, int setE, int maxNumberOfE) {
          int numberOfElements    = numberOfE;
          String[] setElements    = new String[setE];
          int maxNumberOfElements = maxNumberOfE;
       }

       // Helper method to shorten/remove element of array since we're using basic array instead of ArrayList or HashSet from collection interface :(

       static String[] removeAt(int k, String[] arr) {
           final int L = arr.length;
           String[] ret = new String[L - 1];
           System.arraycopy(arr, 0, ret, 0, k);
           System.arraycopy(arr, k + 1, ret, k, L - k - 1);
           return ret; 
       }

       int findElement(String element) {
          int retval = 0;

            for ( int i = 0; i < setElements.length; i++) {

               if ( setElements[i] != null && setElements[i].equals(element) ) {
                  return retval = i;

               }
            retval = -1; 
           }

          return retval;
       }

       void add(String newValue) {
            int elem = findElement(newValue);
            if( numberOfElements < maxNumberOfElements && elem == -1 ) {
               setElements[numberOfElements] = newValue;
               numberOfElements++;
            } 
       }

       int getLength() {
           if ( setElements != null ) {
                return setElements.length;
           }
           else {
                return 0;
           }
       }

       String[] emptySet() {
          setElements = new String[0];
          return setElements;
       }


      Boolean isFull() {
           Boolean True = new Boolean(true);
           Boolean False = new Boolean(false);
          if ( setElements.length == maxNumberOfElements ){
                return True; 
          } else { return False; }
       }

      Boolean isEmpty() {
            Boolean True  = new Boolean(true);
            Boolean False = new Boolean(false);

            if ( setElements.length == 0 ) {
                return True;
            } else {  return False; }
       }

       void remove(String newValue) {

            for ( int i = 0; i < setElements.length; i++) {
               if ( setElements[i].equals(newValue) ) {
                    setElements = removeAt(i,setElements);

               }
            }

       }   

        int isAMember(String element) {
           int retval = -1;

           for ( int i = 0; i < setElements.length; i++ ) {
                if (setElements[i] != null && setElements[i].equals(element)) {
                     return retval  = i;
                }   
           }
           return retval;
       }

       void printSet() {
            for ( int i = 0; i < setElements.length; i++) {
               System.out.println("Member elements on index: "+ i +" " + setElements[i]);
            }
       }

       String[] getMember() {
            String[] tempArray = new String[setElements.length];
            for ( int i = 0; i < setElements.length; i++) {
               if(setElements[i] != null) {
                    tempArray[i] = setElements[i];
               }
            }
            return tempArray;
       }

       Set union(Set x, Set y) {
          String[] newtemparray = new String[x.getLength];
          newtemparray = x.getMember;
          return x;
       }

}

// This is the SetDemo class that will make use of  our Set class

class SetDemo {
     public static void main(String[] args) {
          //get input from keyboard
          BufferedReader keyboard;
          InputStreamReader reader;
          String temp = "";

          reader =   new InputStreamReader(System.in);
          keyboard = new BufferedReader(reader);


      try 
          {
               System.out.println("Enter string element to be added" );
               temp = keyboard.readLine( );
               System.out.println("You entered " + temp );
          }
     catch (IOException IOerr)
          {
               System.out.println("There was an error during input");
          }

     /* 
      **************************************************************************
      * Test cases for our new created Set class.
      *
      **************************************************************************
     */
     Set setA = new Set(1,10,10);
     setA.add(temp);
     setA.add("b");
     setA.add("b");
     setA.add("hello");
     setA.add("world");
     setA.add("six");
     setA.add("seven");
     setA.add("b");
     int size = setA.getLength();
     System.out.println("Set size is: " + size );
     Boolean isempty = setA.isEmpty();
     System.out.println("Set is empty? " + isempty );
     int ismember = setA.isAMember("sixb");
     System.out.println("Element six is member of setA? " + ismember );
     Boolean output = setA.isFull();
     System.out.println("Set is full? " + output );
     setA.printSet();
     int index   = setA.findElement("world");
     System.out.println("Element b located on index: " + index );
     setA.remove("b");
     setA.emptySet();
     int resize = setA.getLength();
     System.out.println("Set size is: " + resize );
     setA.printSet();
     Set setB = new Set(0,10,10);
     Set SetA = setA.union(setB,setA);
     }
}

Ok the method in question will be the implementation of union. As such this:

Set union(Set x, Set y) {
          String[] newtemparray = new String[x.getLength];
          newtemparray = x.getMember;
          return x;
       }

I got this error:

symbol  : variable getLength
location: class Set
          String[] newtemparray = new String[x.getLength];
                                              ^
d:\javaprojects\Set.java:122: cannot find symbol
symbol  : variable getMember
location: class Set
          newtemparray = x.getMember;
                          ^
2 errors

My approach for union would be:

*) create temporary array of string with size of the object x length. *) store object x members to temporary array by looping the object and calling the getMember *) loop object y members and check if element exist against temporary array. *) discard if it exist/add if it is not there *) return obj x with the union array.

thanks, lupin

A: 

The problem you are having is that x.getLength is a function, not a member. You need to call x.getLength() instead.

Mark Robinson
Oh thanks, but I curios on setElement.length or in array for that matter .length works isn't it a method too? Any link where I can read more about this?with thanks lupin
lupindeterd
`length` is a property of an array in java. It's not a method call like `getLength()` and `getMember()` in your code.You can read more here: http://www.lkn.ei.tum.de/arbeiten/faq/man/JAVA-tutorial/java/nutsandbolts/arraysAndStrings.html
ryanprayogo
@lupindeterd: see also http://stackoverflow.com/questions/2493502/dot-length-in-java-finding-its-definition
polygenelubricants
+1  A: 

It's x.getLength() and x.getMember(), respectively.

getLength() and getMember() are both methods of the class Set and hence you need the () because you are invoking a method

ryanprayogo