tags:

views:

90

answers:

5

What's the best way to accomplish the following.

I have strings in this format:

$s1 = "name1|type1"; //(pipe is the separator)
$s2 = "name2|type2";
$s3 = "name3"; //(in some of them type can be missing)

Let's assume namen/typeN are strings and they can not contain a pipe.

Since I need to exctract the name/type separetly, I do:

$temp = explode('|', $s1);
$name = $temp[0];
$type = ( isset($temp[1]) ? $temp[1] : '' );

Is there an easier (smarter whatever faster) way to do this without having to do isset($temp[1]) or count($temp).

Thanks!

A: 
if(strstr($temp,"|"))
{
   $temp = explode($s1, '|');
   $name = $temp[0];
   $type = $temp[1];
}
else
{
   $name = $temp[0];
   //no type
}

Maybe?

DrLazer
Just a heads-up: If all you want to do is check if a needle-string is in a haystack-string, then you should use `strpos() !== false`, it's significantly faster than `strstr()`.
pinkgothic
+4  A: 

Note the order of arguments for explode()

list($name,$type) = explode( '|',$s1);

$type will be NULL for $s3, though it will give a Notice

Mark Baker
will still have to check if type is null and assign ' ' to it if so though
Thomas Winsnes
if you do: @list($name,$type) = explode('|', $s1), the notice will be swallowed. @Thomas - leverage php's untyped nature and allow php to type-juggle the null value based on its usage.
Kevin
good point kevin, I stand corrected
Thomas Winsnes
@Mark Baker: i updated the code in the question, thanks for telling me.
Marco Demajo
@Kevin: +1 great comment "NULL is always converted to an empty string.", but will list then store empty string into $type or NULL? Cuuse if it doesn't show a notice but stores a NULL we are back again.
Marco Demajo
@Marco Using Stef's trick of appending a | before the explode guarantees no notice and an empty string in $type unless there is a genuine $type value
Mark Baker
+1  A: 

There is not need to do isset since $temp[1] will exist and content an empty value. This works fine for me:

$str = 'name|type';

// if theres nothing in 'type', then $type will be empty
list($name, $type) = explode('|', $str, 2);
echo "$name, $type";
Cristian
@Casidiablo: I don't undertand the 2 limit you used in explode, what for?
Marco Demajo
@Marco It's just in case...
Cristian
+5  A: 
list($name, $type) = explode('|', s1.'|');
Flavius Stef
Nice trick to handle the potential Notice, and an empty string rather than a null
Mark Baker
@Flavius Stef: nice trick, +1, very interesting.
Marco Demajo
+1  A: 

I'm a fan of array_pop() and array_shift(), which don't error out if the array they use is empty.

In your case, that would be:

$temp = explode('|', $s1);
$name = array_shift($temp);
// array_shift() will return null if the array is empty,
// so if you really want an empty string, you can string
// cast this call, as I have done:
$type = (string) array_shift($temp);
pinkgothic