views:

106

answers:

3

Hi,

I don't think it is hard, just tedious to write: Some small free (as in beer) library where I can put in a String like 1,2-9,33- and it can tell me whether a given number matches that expression. Just like most programs have in their print range dialogs. Special functions for matching odd or even numbers only, or matching every number that is 2 mod 5 (or something like that) would be nice, but not needed.

The only operation I have to perform on this list is whether the range contains a given (nonnegative) integer value; more operations like max/min value (if they exist) or an iterator would be nice, of course.

What would be needed that it does not occupy lots of RAM if anyone enters 1-10000000 but the only number I will ever query is 12345 :-)

(To implement it, I would parse a list into several (min/max/value/mod) pairs, like 1,10,0,1 for 1-10 or 11,33,1,2 for 1-33odd, or 12,62,2,10 for 12-62/10 (i. e. 12, 22, 32, ..., 62) and then check each number for all the intervals. Open intervals by using Integer.MaxValue etc. If there are no libs, any ideas to do it better/more efficient?)

+1  A: 

Apache Commons has NumberRange

http://commons.apache.org/lang/api-2.4/org/apache/commons/lang/math/NumberRange.html

This also seems to fit your needs:

http://gleichmann.wordpress.com/2008/01/21/declarative-programming-a-range-type-for-java/

DVK
but there I still have to split stuff at commas and dashes and parse them myself?
mihi
Looks like neither of these 2 support that piece, no.
DVK
@mihi - The parsing would be easy. I would go with org.apache.commons.lang.math.NumberRange +1
Romain Hippeau
+1  A: 

It sounds like it would be easier to just code it.

Here is python code supporting the range part of your wishes.

>>> def f(n, pattern):
...     ranges = [r.split('-') for r in pattern.split(',')]
...     for a,b in ranges:
...             if (not a or int(a) <= n) and (not b or int(b) >= n):
...                     return True
...     return False
... 
>>> f(4, '-1,2-9,33-')
True
>>> f(11, '-1,2-9,33-')
False
>>> f(100, '-1,2-9,33-')
True
>>> 

It runs in linear time to the string length. If you compile the pattern into an IntervalTree, you can make that logarithmic. The memory usage is always linear.

Thomas Ahle
it sounds, but you still have to test your code. Your code fails for patterns like 1-10,20,42,100-
mihi
And, I still hope to get some nifty extra features I don't have to think about (but the users will like), like it is with regex libraries :)
mihi
+1  A: 

I decided to code it myself indeed. Use at your own risk :-)

/* 
 * NumberExpression.java - a simple number expression parser
 * 
 * Copyright (c) 2010 Michael Schierl
 * 
 * All rights reserved.
 * 
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 * 
 * - Redistributions of source code must retain the above copyright notice,
 *   this list of conditions and the following disclaimer.
 *   
 * - Redistributions in binary form must reproduce the above copyright
 *   notice, this list of conditions and the following disclaimer in the
 *   documentation and/or other materials provided with the distribution.
 *   
 * - Neither name of the copyright holders nor the names of its
 *   contributors may be used to endorse or promote products derived from
 *   this software without specific prior written permission.
 *   
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND THE CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * HOLDERS OR THE CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
 * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
 * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 * TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
 * USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
package numberexpression;

/**
 * An expression that matches nonnegative numbers. This supports cron-like
 * expressions, like <code>1,3-6,100-200,666,1000-3000/5,400-/7</code>,
 * <code>-100,102-</code> or <code>*</code>. Odd or even numbers can be
 * matched either by cron's step syntax, or by suffixing a simple range
 * (without step values) with <code>e</code> or <code>o</code>.
 * 
 * @author Michael Schierl
 */
public class NumberExpression {

    private final NumberRange[] ranges;
    private final int min, max;

    /**
     * Create a new {@link NumberExpression}.
     * 
     * @param pattern
     *            the expression pattern.
     * @throws IllegalArgumentException
     *             if the pattern is malformed
     */
    public NumberExpression(String pattern) {
        String[] parts = pattern.toLowerCase().split(",",-1);
        ranges = new NumberRange[parts.length];
        int min = Integer.MAX_VALUE, max = 0;
        for (int i = 0; i < ranges.length; i++) {
            String part = parts[i];
            try {
                if (part.equals("*")) {
                    ranges[i] = new NumberRange(0, Integer.MAX_VALUE, 0, 1);
                } else if (part.matches("\\*/\\d+")) {
                    ranges[i] = new NumberRange(0, Integer.MAX_VALUE, 0, Integer.parseInt(part.substring(2)));
                } else if (part.matches("\\d+")) {
                    int value = Integer.parseInt(part);
                    ranges[i] = new NumberRange(value, value, 0, 1);
                } else if (part.matches("\\d*-\\d*")) {
                    String[] limits = part.split("-", -1);
                    int from = limits[0].length() == 0 ? 0 : Integer.parseInt(limits[0]);
                    int to = limits[1].length() == 0 ? Integer.MAX_VALUE : Integer.parseInt(limits[1]);
                    if (to < from)
                        throw new IllegalArgumentException("Invalid pattern: " + part);
                    ranges[i] = new NumberRange(from, to, 0, 1);
                } else if (part.matches("\\d*-\\d*/\\d+")) {
                    String[] rangeAndModulus = part.split("/", -1);
                    String[] limits = rangeAndModulus[0].split("-", -1);
                    int from = limits[0].length() == 0 ? 0 : Integer.parseInt(limits[0]);
                    int to = limits[1].length() == 0 ? Integer.MAX_VALUE : Integer.parseInt(limits[1]);
                    int modulus = Integer.parseInt(rangeAndModulus[1]);
                    if (to < from)
                        throw new IllegalArgumentException("Invalid pattern: " + part);
                    ranges[i] = new NumberRange(from, to, from % modulus, modulus);
                } else if (part.matches("\\d*-\\d*[eo]")) {
                    String[] limits = part.substring(0, part.length() - 1).split("-", -1);
                    int from = limits[0].length() == 0 ? 0 : Integer.parseInt(limits[0]);
                    int to = limits[1].length() == 0 ? Integer.MAX_VALUE : Integer.parseInt(limits[1]);
                    if (to < from)
                        throw new IllegalArgumentException("Invalid pattern: " + part);
                    ranges[i] = new NumberRange(from, to, part.charAt(part.length() - 1) == 'o' ? 1 : 0, 2);
                } else {
                    throw new IllegalArgumentException("Invalid pattern: " + part);
                }
                max = Math.max(max, ranges[i].getMax());
                min = Math.min(min, ranges[i].getMin());
            } catch (NumberFormatException ex) {
                throw new IllegalArgumentException("Invalid pattern: " + part);
            }
        }
        this.max = max;
        this.min = min;
    }

    /**
     * Check whether this number expression matches the given number.
     * 
     * @param number
     *            the number to check against
     * @return whether the expression matches the number
     */
    public boolean matches(int number) {
        if (number < min || number > max)
            return false;
        for (int i = 0; i < ranges.length; i++) {
            if (ranges[i].matches(number))
                return true;
        }
        return false;
    }

    /**
     * Return the minimum number that can be matched.
     */
    public int getMinimum() { return min; }

    /**
     * Return the maximum number that can be matched.
     */
    public int getMaximum() { return max; }

    private static class NumberRange {
        private final int min, max, remainder, modulus;

        NumberRange(int min, int max, int remainder, int modulus) {
            this.min = min;
            this.max = max;
            this.remainder = remainder;
            this.modulus = modulus;
        }

        boolean matches(int number) {
            return number >= min && number <= max && number % modulus == remainder;
        }

        int getMin() { return min; }  
        int getMax() { return max; }
    }
}
mihi