Why doesn't this Wordpress $wpdb query work?

Question

Hi,

I am doing the following:

$type = 'attachment';
$images = $wpdb->get_results($wpdb->prepare('

                SELECT p.*
                FROM wp_%d_posts p
                WHERE p.post_parent =%d
                AND p.post_type = "%s"


    ', $blog_id, $page->ID, $type),OBJECT);


var_dump($images);  

If I remove the line 'AND p.post_type = "%s"' then I get results returned, otherwise I get an empty array returned. If I run the query direct against the DB in a mysql client, I get results.

There is no error, just an empty result set. I am doing similar queries throughout my file and they are working so I'm not looking for "dont do it like that" style replies. I am against a tight deadline and just need to understand why this isnt working and fix it.

PHP 5.3, MYSQL 5.1. Wordpress MU 2.9.2

thanks!

Answer 1

Do not Quote "%s". From the WordPress site, "Notice that you do not have to worry about quoting strings. Instead of passing the variables directly into the SQL query, use a %s placeholder for strings and a %d placedolder for integers."

Example:

$wpdb->query( $wpdb->prepare( "UPDATE $wpdb->posts SET post_title = %s WHERE ID = %d", $var, $id ) );

Answer 2

Hi - apologies to all. there is nothing wrong with the query. Its my brain that is wrong.