ansaurus

Question

How can I put PHP and HTML into a PHP array?

Answer 1

+3 A:

the semicolon is missing ;)

Oliver 2010-06-24 11:53:02

+1. I'd suggest you use single quotes to enclose strings if you don't want the variables or escape characters to be interpreted. Its also a little faster, so generally a good practice to prefer single quotes over double quotes

Gunjan 2010-06-24 11:57:24

It still throws an error.

Sam 2010-06-24 12:05:52

Answer 2

A:

Edit: removed the NOWDOC example after having read the linked question explaining the UseCase.

You can easily solve your problem like this:

if(count($schedule) > 0) {
    $rows = '<tr></th>' 
          . implode('</td><td>', $schedule) 
          . '</td></tr>';
}

For your table headers, you can use a similar approach:

if(count($schedule) > 0) {
    $head = '<tr><th>' 
          . implode('</th><th>', array_keys($schedule)) 
          . '</td></tr>';
}

Since you are querying the database only for those columns with a value and do not want the full 24 hours to be displayed, there is no need to check if the db rows contain anything in PHP again. They do. Otherwise they wouldn't have been returned from the query. And since you only want to wrap the content in table cells and headers, all you have to do is implode them with the markup for that.

In additon, do not add inline styles as they make your code less accessible. Some users override styles with user stylesheets and inline styles can disrupt that. Just add a CSS stylesheet or <style> with td { width:32px } instead. Makes the page weigh less too.

Gordon 2010-06-24 12:09:11

Answer 3

+3 A:

You've done it wrong twice:

You're trying to use PHP code as a data. While you should use code result instead
Your PHP code is far from being optimal.

Here you go:

$str = '';
for ($h=0;$h<24;$h++) {
  $sched = "&nbsp;";
  $hour  = str_pad($h, 2, 0, STR_PAD_LEFT);
  if (isset($schedule["$hour:00"])) $sched = $schedule["$hour:00"]; 
  $str  .= "<td style=\"width:32px\">$sched</td>";
}
$day[$i++] = $str;

Feel the power of programming!

Col. Shrapnel 2010-06-24 12:27:37

THANKS, 24 `if` s were hurting my brain

kemp 2010-06-24 12:37:43

+1 for elegance !

FreekOne 2010-06-24 13:24:31

Keeping the inline styles is far from being optimal either, as it adds code bloat and hampers accessibility. Initializing $sched with when you are only adding it when you overwrite it anyway is odd too. And in fact, the entire loop is not needed.

Gordon 2010-06-24 14:20:08

@Gordon nice points. I've thought already to adapt this code to template use. Though overwriting is just replacement for `else` statement. Or you can call it variable definition :) And your shoot for no loop is excellent :)

Col. Shrapnel 2010-06-24 15:45:27

Agreed. I misread the code. I am not used to `if` one liners (I consider it a coding style violation). However, in this case you are creating 24 cells, when the OP did ask for only those with a value.

Gordon 2010-06-24 16:03:16

@Gordon yeah, intentionally. I don't know the whole case, but resulting table would look messy otherwise. That's obviously a schedule, and it must have straight columns, I believe :)

Col. Shrapnel 2010-06-24 16:11:15

Answer 4

A:

Use like this,

<?php
$day[$i++] = "<tr>";
if(isset($schedule['00:00'])) { 
   $day[$i++] .= "<td style=\"width:32px\">".$schedule['00:00']."</td>";
}
if(isset($schedule['02:00'])) {
   $day[$i++] .= "<td style=\"width:32px\">".$schedule['02:00']."</td>";
} if(isset($schedule['03:00'])) { 
    $day[$i++] .= "<td style=\"width:32px\">".$schedule['03:00']."</td>";
} ......................

?>

Karthik 2010-06-24 12:31:32

Seeng noone using loop in this topic makes me pain

Col. Shrapnel 2010-06-24 12:39:15

He is asking about writing the code without error and not a flow wise suggestion.

Karthik 2010-06-24 12:44:19

ansaurus

tags:

views:

answers:

How can I put PHP and HTML into a PHP array?

related questions