if condition not working

Question

if ( ( ($_FILES["file"]["type"] == "image/gif") ||
       ($_FILES["file"]["type"] == "image/jpeg") || 
       ($_FILES["file"]["type"] == "image/pjpeg") ) && 
     ($_FILES["file"]["size"] < 20000))
   {
      header ("Location: index.html");
   }

i am using the above code to redirect the page to index.html if user has uploaded any image. but it is not working. the page is not getting redirected. can anybody help me?

Thanks in advance

Answer 1

if user has uploaded any image. but it is not working. the page is not getting redirected. can anybody help me?

That's very vague - what are they uploading? How do you know its not working?

if user has uploaded any image

No - only if the users browser thinks that the file is one of the 3 types you've listed.

Answer 2

PHP: header - manual:

Remember that header() must be called before any actual output is sent, either by normal HTML tags, blank lines in a file, or from PHP.

Answer 3

Given this comment...

the user are supposed to submit pdf or word file. the page remains blank instead of redirecting the page

This statement checks that the image is a gif, jpeg or pjpeg and if it IS one of these it redirects. As the image will be of type pdf or doc, it won't satisfy the condition.

if ( ( ($_FILES["file"]["type"] == "image/gif") ||
       ($_FILES["file"]["type"] == "image/jpeg") || 
       ($_FILES["file"]["type"] == "image/pjpeg") ) && 
     ($_FILES["file"]["size"] < 20000))
   {
      header ("Location: index.html");
   }

I would suggest that you want to either remove this if statement entirely and just use the "header(..." line - or you want to check that the file is the correct type and display a message telling people that it isn't...

if ($_FILES["file"]["type"] == "application/pdf") {
    header ("Location: index.html");
} else {
    echo 'Incorrect File Type';
}

Answer 4

Does the Redirect work, without the if-condition? Maybe it's not the if-condition which is not working, but some mistake within your redirect-command. This sometimes is kinda weird, with header('Location: ...');

Answer 5

$_FILES["file"]["type"] depends on what the client sends to the server.
Use getimagesize() to determine the mimetype on the server.

Invoke the exit(); after the redirect.
Because the script keeps running and could modify the HTTP status from 301(redirect) back to something like 200, 404, 500, etc.

You could further debug your if statement by adding:

  // ...
  header ("Location: index.html");
  exit();
} else {
  var_dump($_FILES["file"]);
}

Answer 6

thanks a lot everyone i have got the solution. actually i was missing out to complete a brace