views:

1584

answers:

14

Edit on 11/26 - Please note - I am not looking for the "right" way to open/read a file, or the way I should open/read a file every single time. I was just interested to find out what way most people use, and maybe learn a few new methods at the same time :)

A very common block of code in my perl programs is opening a file and reading or writing to it. I have seen so many ways of doing this, and my style on performing this task has changed over the years a few times. I'm just wondering what the best (if there is a best way) method is to do this?

I used to open a file like this:

my $input_file = "/path/to/my/file";
open INPUT_FILE, "<$input_file"  || die "Can't open $input_file: $!\n";

but I think that has problems with error trapping.

Adding parenthesis seems to fix the error trapping:

open (INPUT_FILE, "<$input_file")  || die "Can't open $input_file: $!\n";

I know you can also assign a filehandle to a variable, so instead of using "INPUT_FILE" like I did above, I could have used $input_filehandle - is that way better?

For reading a file, if it is small, is there anything wrong with globbing, like this?

my @array = <INPUT_FILE>;

or

my $file_contents = join( "\n", <INPUT_FILE> );

or should you always loop through, like this:

my @array;
while (<INPUT_FILE>) {
  push(@array, $_);
}

I know there are so many ways to accomplish things in perl, I'm just wondering if there are preferred/standard methods of opening and reading in a file?

+14  A: 

There are no universal standards, but there are reasons to prefer one or another. My preferred form is this:

open( $input_fh, "<", $input_file ) || die "Can't open $input_file: $!";

The reasons are:

  • You report errors immediately. (Replace "die" with "warn" if that's what you want.)
  • Your filehandle is now reference-counted, so once you're not using it it will be automatically closed. If you use the global name INPUT_FILEHANDLE, then you have to close the file manually or it will stay open until the program exits.
  • The read-mode indicator "<" is separated from the $input_file, increasing readability.

The following is great if the file is small and you know you want all lines:

my @lines = <$input_fh>;

You can even do this, if you need to process all lines as a single string:

my $text = join('', <$input_fh>);

For long files you will want to iterate over lines with while, or use read.

JSBangs
or slight variation... open my $input_fh, '<', $input_file or die "Can't open $input_file: $!";
draegtun
I still think that this is boilerplate. Just use `File::Slurp` or `Tie::File`.
Svante
+5  A: 

The perlopentut man page covers most of this issue pretty well.

converter42
+10  A: 

If you want the entire file as a single string, theres no need to iterate through it.

use strict;
use warnings;
use Carp;
use English qw( -no_match_vars ); 
my $data = q{}; 
{ 
   local $RS = undef; # this makes it just read the whole thing,
   my $fh; 
   croak "Can't open $input_file: $!\n" if not open $fh, '<', $input_file;
   $data = <$fh>; 
   croak 'Some Error During Close :/ ' if not close $fh;
}

Edit: The above now satisfies perlcritic --brutal, which is a good way to test for 'best practices' :). $input_file is still undefined here, but the rest is kosher.

Kent Fredric
+1  A: 

If these programs are just for your productivity, whatever works! Build in as much error handling as you think you need.

Reading in a whole file if it's large may not be the best way long-term to do things, so you may want to process lines as they come in rather than load them up in an array.

One tip I got from one of the chapters in The Pragmatic Programmer (Hunt & Thomas) is that you might want to have the script save a backup of the file for you before it goes to work slicing and dicing.

John at CashCommons
+7  A: 

If your files are small enough that reading the whole thing into memory is feasible, use File::Slurp. It reads and writes full files with a very simple API, plus it does all the error checking so you don't have to.

Dave Rolsky
+5  A: 

There is no best way to open and read a file. It's the wrong question to ask. What's in the file? How much data do you need at any point? Do you need all of the data at once? What do you need to do with the data? You need to figure those out before you think about how you need to open and read the file.

Is anything that you are doing now causing you problems? If not, don't you have better problems to solve? :)

Most of your question is merely syntax, and that's all answered in the Perl documentation (especially (perlopentut). You might also like to pick up Learning Perl, which answers most of the problems you have in your question.

Good luck, :)

brian d foy
So maybe I shouldn't have asked what the best way to open/read a file is, but what do most people do. I've written hundreds of perl programs that open files, and just want to make sure I'm going about it in a good way. I haven't had any problems - I'm just curious how other people do it. Thanks!
BrianH
Again, read the first paragraph. The best way depends on what you are doing.
brian d foy
I'm not saying the Perl::Critic is law, but many of the ways to open files in "Learning Perl" do not pass Perl::Critic. In fact, the way I used to open files all the time is the way I learned it in "Learning Perl". I would argue that best practices can be applied to most situations where a file needs to be opened, and that you don't need to know the tiny details - otherwise I would ask, "What's the best way to open a binary file and count the bytes" or something like that. 99% of the files I open are plain text, and I just want to read it into an array. I'm interested to know best practice
BrianH
You must have an old Learning Perl then.
brian d foy
That could be - 3rd addition, 2002 - I'll have to look for a newer version.
BrianH
You don't have to look hard to find the Fifth edition, which is the current one.
brian d foy
Went out and bought the 5th addition - glad I did - there are some great updates!Critic doesn't appreciate bareword file handles, and I don't see examples in the 5th edition where non-bareword file handles are used. Again - not saying Critic is the law, but that was the point of my question: PBP/Critic says to use 3 argument opens, and non-bareword file handles. Learning Perl does not show examples of non-bareword file handles (that I can find). Not saying either way is right/wrong - but my question was to see how most people do it.
BrianH
+3  A: 

For OO, I like:

use FileHandle;
...
my $handle = FileHandle->new( "< $file_to_read" );
croak( "Could not open '$file_to_read'" ) unless $handle;
...
my $line1 = <$handle>;
my $line2 = $handle->getline;
my @lines = $handle->getlines;
$handle->close;
Axeman
And then do you read it with <$handle> ?
BrianH
Yes, it will work with the "iteration operator", but you can also read it with $handle->getline or $handle->getlines
Axeman
+1  A: 

There's lots of great discussion of various approaches to slurping in whole files here:

http://www.sysarch.com/Perl/slurp_article.html

bigiain
A: 

It's true that there are as many best ways to open a file in Perl as there are

$files_in_the_known_universe * $perl_programmers

...but it's still interesting to see who usually does it which way. My preferred form of slurping (reading the whole file at once) is:

use strict;
use warnings;

use IO::File;

my $file = shift @ARGV or die "what file?";

my $fh = IO::File->new( $file, '<' ) or die "$file: $!";
my $data = do { local $/; <$fh> };
$fh->close();

# If you didn't just run out of memory, you have:
printf "%d characters (possibly bytes)\n", length($data);

And when going line-by-line:

my $fh = IO::File->new( $file, '<' ) or die "$file: $!";
while ( my $line = <$fh> ) {
    print "Better than cat: $line";
}
$fh->close();

Caveat lector of course: these are just the approaches I've committed to muscle memory for everyday work, and they may be radically unsuited to the problem you're trying to solve.

+1  A: 

I once used the

open (FILEIN, "<", $inputfile) or die "...";
my @FileContents = <FILEIN>;
close FILEIN;

boilerplate regularly. Nowadays, I use File::Slurp for small files that I want to hold completely in memory, and Tie::File for big files that I want to scalably address and/or files that I want to change in place.

Svante
+4  A: 

Having to write 'or die' everywhere drives me nuts. My preferred way to open a file looks like this:

use autodie;

open(my $image_fh, '<', $filename);

While that's very little typing, there are a lot of important things to note which are going on:

  • We're using the autodie pragma, which means that all of Perl's built-ins will throw an exception if something goes wrong. It eliminates the need for writing or die ... in your code, it produces friendly, human-readable error messages, and has lexical scope. It's available from the CPAN.

  • We're using the three-argument version of open. It means that even if we have a funny filename containing characters such as <, > or |, perl will still do the right thing. In my Perl Security tutorial at OSCON I showed a number of ways to get 2-argument open to misbehave. The notes for this tutorial are available for free download from Perl Training Australia.

  • We're using a scalar filehandle. This means that we're not going to be coincidently closing someone else's filehandle of the same name, which can happen if we use package filehandles. It also means strict can spot typos, and that our filehandle will be cleaned up automatically if it goes out of scope.

  • We're using a meaningful filehandle, in this case it looks like we're going to write to an image.

  • The filehandle ends with _fh. If we see us using it like a regular scalar, then we know that it's probably a mistake.

All the best,

Paul

pjf
Great insight, thanks! I also had never seen the 3 argument method to "open" - I think I like that way!Thanks!
BrianH
A: 

Read the entire file $file into variable $text with a single line

$text = do {local(@ARGV, $/) = $file ; <>};

or as a function

$text = load_file($file);
sub load_file {local(@ARGV, $/) = @_; <>}
A: 

Damian Conway does it this way:

$data = readline!open(!((*{!$_},$/)=\$_)) for "filename";

But I don't recommend that to you.

ysth
+1  A: 

the || operator has higher precidence, so it is evaluated first before sending the result to "open"... in the code you've mentioned, use the "or" operator instead and you wouldn't have that problem.

open INPUT_FILE, " or die "Can't open $input_file: $!\n";

Ape-inago