What is the right way to use JDBC transactions in Java?

Question

I'm using this template:

try {
    connection.setAutoCommit(false);

    try {
        // ... do something with that connection ...
        connection.commit();
    catch (SQLException exception) {
        connection.rollback();
        throw exception;
    } finally {
        connection.setAutoCommit(true);
    }
} catch (SQLException exception) {
    // log error
}

Is this the right way? How can this template be improved?

Answer 1

Your code should work fine. Do you get any errors or anything else?

Here's an example on using JDBC Transaction anyway

http://www.java2s.com/Code/Java/Database-SQL-JDBC/JDBCTransaction.htm

P.S. Specify your problem and I'll try to help.