Error uploading file from HTML form

Question

Here is a problem. I have an HTML form with several fields in it. One of the fields - 'Upload file'. When I upload a file, everything works properly. But when I choose to submit the form without a file, it gives me the error message: "There was an error uploading the file, please try again". Looks to me that the script thinks that uploading a file is mandatory. How do I change it?

Here is my PHP:

//File upload

// Where the file is going to be placed 
$target_path = "uploads/";

// Add the original filename to our target path.  
//Result is "uploads/filename.extension" 
$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
    echo "The file ".  basename( $_FILES['uploadedfile']['name']). 
    " has been uploaded";
} else{
    echo "There was an error uploading the file, please try again!";
}   

//End of file upload

Thank you!

Answer 1

You should check using the function is_uploaded_file

try adding the following condition before calling the function move_uploaded_file

if (is_uploaded_file($_FILES['uploadedfile']['tmp_name'])) {

Answer 2

move_uploaded_file returns a bool, true or false, depending on the success of the operation.

A solution would be to check more rigorously, e.g. if a file was uploaded at all via is_uploaded_file function.

For proper working, the function is_uploaded_file() needs an argument like $_FILES['userfile']['tmp_name'], - the name of the uploaded file on the clients machine $_FILES['userfile']['name'] does not work.

Answer 3

The target path of move_uploaded_files should be a folder, not a file.

You should also check if the folder is_writeable and is_dir.