phpcode generating broken javascript and html code

Question

Hello,

I have the following PHP code pasted here:

http://www.nomorepasting.com/getpaste.php?pasteid=22461

Which produces the following html code:

http://www.nomorepasting.com/getpaste.php?pasteid=22462

My problem is that the popup window is not created, or if it is created that it is empty. I have used JSON encode as previously suggested, but that does not seem to work.

Also, no image is displayed, despite PIC_URL being a correct image. apprantly this is because of an unclosed style tag, however I do not know why that is being generated, or how to prevent it.

I would also like to know the best way to insert newlines into my php, so the generated html is not a contiguous block.

edit: ARTICLE_DESC is definitely not empty, despite what people are saying. However, I have used a different record to double check, and there is still the same problem, although img src and document.write are n o longer blank. The resulting html is here:

http://www.nomorepasting.com/getpaste.php?pasteid=22468

It definitely seem to be a problem with the unclosed <style ty tag, but I see nothing responsible for generating that in the php

Answer 1

Have you try without json_encode? Maybe this function returns bad value?

Answer 2

Putting the HTML markup into your .js file, AJAX fetching just the values returned by MySQL query and plugging them in could fix it, not sure if this can be applied in your situation though. I think the & in "Ed Hardy Damen T-Shirt Skulls & Butterfly, Gr.M Neu+OVP" may be what breaks the whole thing, tried it on an entry without & in it?

Answer 3

The picture is not displayed because you have <img src=""/>, which obviously isn't pointing anywhere. I would print_r($row) for a test and make sure that $row['PIC_URL']; is valid.

It also looks like $row2["ARTICLE_DESC"] has got nothing in it - I would check that your second query is actually returning a record - try doing something like:

$htmlset = mysql_query($sql2);
if (!$htmlset) die ('cannot find html description..');

Edit

It looks like lower down in the page your data from the database contains malformed HTML. It maybe worth putting this line in:

$row = array_map('htmlspecialchars', $row);

directly beneath the line while ($row = mysql_fetch_array($result))

This will cause the bad HTML to be displayed literally rather than parsed as HTML by the browser, and it should therefore not break the rest of the page.