views:

111

answers:

4

I need a data structure to store string-int value pairs in an 1:1 relationship, and being able too look up from either way their counterpart.

I wrote a class with a Hashtable and a String array and stored the data 2 times and used the built in functions for lookup.

My question is that is there a nicer way to accomplish this? And by nicer I mean being efficient and not storing the data 2 times, and preferably without writing a ton of code either :P.

+2  A: 

The Google Collections Framework has a BiMap that does what you want.

jqno
yup that does it! I couldn't find anything by searching for "2 way map" :P it seems bidirectional map is the right term
sekmet64
+5  A: 

It seems like you may be looking for a bimap.

The Google Collections (now a part of Guava) contains an BiMap interface with a few implementations.

From the BiMap documentation:

A bimap (or "bidirectional map") is a map that preserves the uniqueness of its values as well as that of its keys. This constraint enables bimaps to support an "inverse view", which is another bimap containing the same entries as this bimap but with reversed keys and values.

The BiMap.inverse method appears to return a Map with the values as the keys, and the keys as the values, so that Map can be used to call get on the value and retrieve a key.

In addition the Map returned by inverse is a view of the underlying data, so it does not have to make extra copies of the original data.

From the BiMap.inverse method documentation:

Returns the inverse view of this bimap, which maps each of this bimap's values to its associated key. The two bimaps are backed by the same data; any changes to one will appear in the other.

coobird
A: 

Create a hashmap that maps Object to Object - then you can use the same map to store String -> Integer and Integer -> String.

When you add a string/int pair just add it both ways to the same map.

Dave Kirby
This is not a very sensible implementation at all. You throw all the generic type safety out the window, and increase the complexity of all the operations carried out on the map by double-adding entries. There is no encapsulation of the mechanism by which you are implementing the bi-directional map.
Tom
@Tom - I wrote the answer in a hurry and assumed the implementer would be sensible enough to wrap the hashmap in a class that controlled access to it and did the casting to the required types. I will try to be clearer on that point in future.
Dave Kirby
Another problem you could run into is storing A->B and B->C, which should be fine with the question but not with your answer.
DerMike
A: 

You can do a simple implementation like this. Please note that the data is not copied in this implementation. Only the references are ! I have added implementation for add and get. remove and other required method are left as exercise :)

public class TwoWayHashmap<K extends Object, V extends Object> {

  private Map<K,V> forward = new Hashtable<K, V>();
  private Map<V,K> backward = new Hashtable<V, K>();

  public synchronized void add(K key, V value) {
    forward.put(key, value);
    backward.put(value, key);
  }

  public synchronized V getForward(K key) {
    return forward.get(key);
  }

  public synchronized K getBackward(V key) {
    return backward.get(key);
  }
}

And ofcourse its applications responsibility to ensue even the 'values' are unique. Example usage:

TwoWayHashmap twmap = new TwoWayHashmap<String, String>();
twmap.add("aaa", "bbb");
twmap.add("xxx", "yyy");
System.out.println(twmap.getForward("xxx"));
System.out.println(twmap.getBackward("bbb"));
Gopi
Would be an interesting approach in the absence of Guava's BiMap. However, I'd suggest that you have this class implement the Map interface.
Noel M